Fix one inspector test #20072
Merged
Fix one inspector test #20072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
test
Feature:Visualizations
💚 Build Succeeded |
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Jun 20, 2018
timroes
added a commit
that referenced
this pull request
Jun 21, 2018
…st (#20072) (#20076) * Replace spy panels by Inspector (#16387) * Add Inspector feature * So long, and thanks for all the fish, spy panel * Fix several functional tests * Fix unit tests * Fix spy panel button tests * Replace old spy panel documentation * Disable test temporarily until we have dashboard triggers * Enter edit mode for dark theme test * Fix some more functional tests * Fix more functional tests * More test fixing * Fix more functional tests * Allow opening the inspector via loader handler * Refactor InspectorViewChooser, remove unused CSS * Remove dead code * Fix data download button style * Remove redundant code * Load inspectorViews for dashboard_viewer * Extract inspector views to custom core_plugin * Switch API to TypeScript 🎉 * Design changes * Remove icons from views * Design changes * Improve typings of API * Add typing to all adapters * Show loading spinner in request selector * Rewrite InspectorView to TypeScript * Fix help text for data view * Remove deprecated React lifecycle methods * Embed inspector into dashboard panel actions * Remove temporary inspector trigger * Remove old CSS * Fix dashboard trigger for new panel action * Add tests for InspectorPanel and DataAdapter * Produce a hierarchical table if the vis is hierarchical * Remove allowJs option again * Add missing Apache license headers * Close inspector on dashboard when navigating away * Use proper title for dashboard panels * Fix functional tests * Skip broken test for now * Flush view chooser button * Add request adapter tests * Skip more tests, broken due to typescript * Add Request Time description * Add description for courier request * Fix tests * Replace icon by new (not yet released) icon * Finalize design of inspector * Remove discover test, that relied on spy panels * Change API to be properly mockable in tests * Add aria-live region for request status * Replace old method in functional tests * Replace abitrary magic number * Use object destructuring in vis * Fix issue with crashing requests view * Add request time tooltip * Get request body of correct search source * Make filter buttons properly keyboard accessible * Follow Dave's design suggestions * Remove redundant request from name * Remove unneeded comments * WIP raw-formatted values * Fix filtering issue * Fix tests and more license headers * Add data view tests * Remove search from table * Fix typos * Implement review suggestion * Remove artificial delays for testing * Fix new panel action structure * Minor design adjustments * Fix failing functional test * Update failing snapshot test * Implement final wording * Apply new EUI styling * Fix closing inspector in tests * Fix sorting of table * Align punctuation between tooltips * Fix test that doesn't exist on master * Fix one inspector test (#20072) * Remove file that came accidentally back due to merging * Fix accidental merge paste * Fix 6.4 test failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one fixes one inspector test, that strangely have passed on master every time, but now failed on 6.4. Looking at that issue: enzymejs/enzyme#1600 I wonder how it ever passed on master, since
setPropsapparently does not callgetDerivedStateFromPropsif you useshallowrendering, which should always makes this test fail... but it didn't on master.