-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataUsage][Serverless] UX/API changes based on demo feedback #200911
[DataUsage][Serverless] UX/API changes based on demo feedback #200911
Conversation
1978600
to
99dbbba
Compare
) : null} | ||
<ChartsLoading data-test-subj={dataTestSubj} /> | ||
) : ( | ||
<NoDataCallout data-test-subj={dataTestSubj} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shows no data callout instead of nothing. We did this as we now allow deselecting all data streams. We don't send a network request in this case though!
@@ -118,10 +123,16 @@ export const DataUsageMetrics = memo( | |||
}, | |||
{ | |||
retry: false, | |||
enabled: !!metricsFilters.dataStreams.length, | |||
enabled: !!(metricsFilters.dataStreams.length && metricsFilters.metricTypes.length), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the network request logic to work only if there are metric types and data streams. In case we show the metric types filter in the future (which also allows selecting/de-selecting all metric types) we shouldn't request data in that case
@@ -33,6 +35,8 @@ export const DataUsageMetrics = memo( | |||
({ 'data-test-subj': dataTestSubj = 'data-usage-metrics' }: { 'data-test-subj'?: string }) => { | |||
const getTestId = useTestIdGenerator(dataTestSubj); | |||
|
|||
const [isFirstPageLoad, setIsFirstPageLoad] = useState(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to ensure not to overwrite data streams to URL when we click on clear all
data streams filter
endDate: moment().toISOString(), | ||
startDate: 'now-24h/h', | ||
endDate: 'now', | ||
maxDate: 'now+1s', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes the issue of false invalid date error on UX even when the dates are valid
logger.debug(`Retrieving usage metrics`); | ||
const { data_streams: dataStreams } = await getDataStreams(requestDsNames); | ||
dataStreamsResponse = dataStreams; | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sets of 50 data streams and verify them in parallel if more than 50 datastreams were in the request
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
miscellaneous assets size
History
cc @ashokaditya |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11982651613 |
…c#200911) ## Summary Adds a bunch of UX updates based on the feedback after demo. - [x] Tidy chart legend action popup and links - [x] fix UX date picker invalid time (UX shows invalid time falsely) - [ ] Tooltip for date filter - [ ] send UTC time to requests (1:1 mapping for date-time picked vs date-time sent) - [x] Remove unusable common date filter shortcuts - [x] data stream filter `select all` - [x] data stream filter `clear all` - [x] No charts empty state - [x] filter in datastreams that have greater than `0` bytes storage size - [ ] Filter out system indices from data stream filter? - [x] Taller filter popover list for larger lists Follow up of elastic#200731 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e48f930)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…200911) (#201486) # Backport This will backport the following commits from `main` to `8.x`: - [[DataUsage][Serverless] UX/API changes based on demo feedback (#200911)](#200911) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-23T01:08:24Z","message":"[DataUsage][Serverless] UX/API changes based on demo feedback (#200911)\n\n## Summary\n\nAdds a bunch of UX updates based on the feedback after demo. \n\n- [x] Tidy chart legend action popup and links\n- [x] fix UX date picker invalid time (UX shows invalid time falsely)\n- [ ] Tooltip for date filter\n- [ ] send UTC time to requests (1:1 mapping for date-time picked vs\ndate-time sent)\n- [x] Remove unusable common date filter shortcuts\n- [x] data stream filter `select all`\n- [x] data stream filter `clear all`\n- [x] No charts empty state\n- [x] filter in datastreams that have greater than `0` bytes storage\nsize\n- [ ] Filter out system indices from data stream filter?\n- [x] Taller filter popover list for larger lists\n\nFollow up of https://github.com/elastic/kibana/pull/200731\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_node:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"e48f930ab32b5c325ad38175e41f93ec0b8c4ba7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:build-serverless-image"],"title":"[DataUsage][Serverless] UX/API changes based on demo feedback","number":200911,"url":"https://github.com/elastic/kibana/pull/200911","mergeCommit":{"message":"[DataUsage][Serverless] UX/API changes based on demo feedback (#200911)\n\n## Summary\n\nAdds a bunch of UX updates based on the feedback after demo. \n\n- [x] Tidy chart legend action popup and links\n- [x] fix UX date picker invalid time (UX shows invalid time falsely)\n- [ ] Tooltip for date filter\n- [ ] send UTC time to requests (1:1 mapping for date-time picked vs\ndate-time sent)\n- [x] Remove unusable common date filter shortcuts\n- [x] data stream filter `select all`\n- [x] data stream filter `clear all`\n- [x] No charts empty state\n- [x] filter in datastreams that have greater than `0` bytes storage\nsize\n- [ ] Filter out system indices from data stream filter?\n- [x] Taller filter popover list for larger lists\n\nFollow up of https://github.com/elastic/kibana/pull/200731\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_node:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"e48f930ab32b5c325ad38175e41f93ec0b8c4ba7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200911","number":200911,"mergeCommit":{"message":"[DataUsage][Serverless] UX/API changes based on demo feedback (#200911)\n\n## Summary\n\nAdds a bunch of UX updates based on the feedback after demo. \n\n- [x] Tidy chart legend action popup and links\n- [x] fix UX date picker invalid time (UX shows invalid time falsely)\n- [ ] Tooltip for date filter\n- [ ] send UTC time to requests (1:1 mapping for date-time picked vs\ndate-time sent)\n- [x] Remove unusable common date filter shortcuts\n- [x] data stream filter `select all`\n- [x] data stream filter `clear all`\n- [x] No charts empty state\n- [x] filter in datastreams that have greater than `0` bytes storage\nsize\n- [ ] Filter out system indices from data stream filter?\n- [x] Taller filter popover list for larger lists\n\nFollow up of https://github.com/elastic/kibana/pull/200731\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [x] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_node:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"e48f930ab32b5c325ad38175e41f93ec0b8c4ba7"}}]}] BACKPORT--> Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
…c#200911) ## Summary Adds a bunch of UX updates based on the feedback after demo. - [x] Tidy chart legend action popup and links - [x] fix UX date picker invalid time (UX shows invalid time falsely) - [ ] Tooltip for date filter - [ ] send UTC time to requests (1:1 mapping for date-time picked vs date-time sent) - [x] Remove unusable common date filter shortcuts - [x] data stream filter `select all` - [x] data stream filter `clear all` - [x] No charts empty state - [x] filter in datastreams that have greater than `0` bytes storage size - [ ] Filter out system indices from data stream filter? - [x] Taller filter popover list for larger lists Follow up of elastic#200731 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary Follow up of #200911 - [x] Treat date picker values as UTC date/time - [ ] Tooltip for date picker - [x] Align filters (right aligned for all screens and responsive) - [x] Disable `refresh` button if no `metricTypes` or `dataStreams` or invalid date range - [x] Validate selected date/time range before sending requests ![Screenshot 2024-11-25 at 17 25 43](https://github.com/user-attachments/assets/bc61ad73-2c85-4b40-9156-c5ccc87e0d7e) ![Screenshot 2024-11-25 at 17 27 53](https://github.com/user-attachments/assets/3aef26d1-6df2-4315-a939-0807c9da18c7) ![Screenshot 2024-11-26 at 15 45 56](https://github.com/user-attachments/assets/f7e1da72-4559-42e0-bee2-2e53709fd812) ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
## Summary Follow up of elastic#200911 - [x] Treat date picker values as UTC date/time - [ ] Tooltip for date picker - [x] Align filters (right aligned for all screens and responsive) - [x] Disable `refresh` button if no `metricTypes` or `dataStreams` or invalid date range - [x] Validate selected date/time range before sending requests ![Screenshot 2024-11-25 at 17 25 43](https://github.com/user-attachments/assets/bc61ad73-2c85-4b40-9156-c5ccc87e0d7e) ![Screenshot 2024-11-25 at 17 27 53](https://github.com/user-attachments/assets/3aef26d1-6df2-4315-a939-0807c9da18c7) ![Screenshot 2024-11-26 at 15 45 56](https://github.com/user-attachments/assets/f7e1da72-4559-42e0-bee2-2e53709fd812) ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... (cherry picked from commit d0d33aa)
…c#200911) ## Summary Adds a bunch of UX updates based on the feedback after demo. - [x] Tidy chart legend action popup and links - [x] fix UX date picker invalid time (UX shows invalid time falsely) - [ ] Tooltip for date filter - [ ] send UTC time to requests (1:1 mapping for date-time picked vs date-time sent) - [x] Remove unusable common date filter shortcuts - [x] data stream filter `select all` - [x] data stream filter `clear all` - [x] No charts empty state - [x] filter in datastreams that have greater than `0` bytes storage size - [ ] Filter out system indices from data stream filter? - [x] Taller filter popover list for larger lists Follow up of elastic#200731 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary Follow up of elastic#200911 - [x] Treat date picker values as UTC date/time - [ ] Tooltip for date picker - [x] Align filters (right aligned for all screens and responsive) - [x] Disable `refresh` button if no `metricTypes` or `dataStreams` or invalid date range - [x] Validate selected date/time range before sending requests ![Screenshot 2024-11-25 at 17 25 43](https://github.com/user-attachments/assets/bc61ad73-2c85-4b40-9156-c5ccc87e0d7e) ![Screenshot 2024-11-25 at 17 27 53](https://github.com/user-attachments/assets/3aef26d1-6df2-4315-a939-0807c9da18c7) ![Screenshot 2024-11-26 at 15 45 56](https://github.com/user-attachments/assets/f7e1da72-4559-42e0-bee2-2e53709fd812) ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
Summary
Adds a bunch of UX updates based on the feedback after demo.
select all
clear all
0
bytes storage sizeFollow up of #200731
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breaking
label should be applied in these situations.release_node:*
label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.