-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Fix to handle ops genie as default connector !! #201923
Conversation
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
@@ -128,6 +131,14 @@ export function populateAlertActions({ | |||
actions.push(recoveredAction); | |||
} | |||
break; | |||
case OPSGENIE_ACTION_ID: | |||
// @ts-expect-error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to avoid @ts-expect-error
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am clueless on how to handle it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Opsgenie connector, worked as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ResponseOps changes LGTM
💚 Build Succeeded
Metrics [docs]
History
|
Starting backport for target branches: 8.15, 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12126428120 |
…#201923) ## Summary fixes elastic#168681 Fix to handle ops genie as default connector !! Tested by creating a trail account in ops genie <img width="1712" alt="image" src="https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7"> (cherry picked from commit a674b9d)
…#201923) ## Summary fixes elastic#168681 Fix to handle ops genie as default connector !! Tested by creating a trail account in ops genie <img width="1712" alt="image" src="https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7"> (cherry picked from commit a674b9d)
…#201923) ## Summary fixes elastic#168681 Fix to handle ops genie as default connector !! Tested by creating a trail account in ops genie <img width="1712" alt="image" src="https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7"> (cherry picked from commit a674b9d)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
…201923) (#202571) # Backport This will backport the following commits from `main` to `8.16`: - [[Synthetics] Fix to handle ops genie as default connector !! (#201923)](#201923) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-12-02T19:20:26Z","message":"[Synthetics] Fix to handle ops genie as default connector !! (#201923)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops genie as default connector !!\r\n\r\nTested by creating a trail account in ops genie \r\n\r\n<img width=\"1712\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics] Fix to handle ops genie as default connector !!","number":201923,"url":"https://github.com/elastic/kibana/pull/201923","mergeCommit":{"message":"[Synthetics] Fix to handle ops genie as default connector !! (#201923)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops genie as default connector !!\r\n\r\nTested by creating a trail account in ops genie \r\n\r\n<img width=\"1712\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201923","number":201923,"mergeCommit":{"message":"[Synthetics] Fix to handle ops genie as default connector !! (#201923)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops genie as default connector !!\r\n\r\nTested by creating a trail account in ops genie \r\n\r\n<img width=\"1712\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
…201923) (#202572) # Backport This will backport the following commits from `main` to `8.17`: - [[Synthetics] Fix to handle ops genie as default connector !! (#201923)](#201923) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-12-02T19:20:26Z","message":"[Synthetics] Fix to handle ops genie as default connector !! (#201923)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops genie as default connector !!\r\n\r\nTested by creating a trail account in ops genie \r\n\r\n<img width=\"1712\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics] Fix to handle ops genie as default connector !!","number":201923,"url":"https://github.com/elastic/kibana/pull/201923","mergeCommit":{"message":"[Synthetics] Fix to handle ops genie as default connector !! (#201923)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops genie as default connector !!\r\n\r\nTested by creating a trail account in ops genie \r\n\r\n<img width=\"1712\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201923","number":201923,"mergeCommit":{"message":"[Synthetics] Fix to handle ops genie as default connector !! (#201923)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops genie as default connector !!\r\n\r\nTested by creating a trail account in ops genie \r\n\r\n<img width=\"1712\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
…201923) (#202573) # Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] Fix to handle ops genie as default connector !! (#201923)](#201923) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-12-02T19:20:26Z","message":"[Synthetics] Fix to handle ops genie as default connector !! (#201923)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops genie as default connector !!\r\n\r\nTested by creating a trail account in ops genie \r\n\r\n<img width=\"1712\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics] Fix to handle ops genie as default connector !!","number":201923,"url":"https://github.com/elastic/kibana/pull/201923","mergeCommit":{"message":"[Synthetics] Fix to handle ops genie as default connector !! (#201923)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops genie as default connector !!\r\n\r\nTested by creating a trail account in ops genie \r\n\r\n<img width=\"1712\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201923","number":201923,"mergeCommit":{"message":"[Synthetics] Fix to handle ops genie as default connector !! (#201923)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops genie as default connector !!\r\n\r\nTested by creating a trail account in ops genie \r\n\r\n<img width=\"1712\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661"}}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
…#201923) ## Summary fixes elastic#168681 Fix to handle ops genie as default connector !! Tested by creating a trail account in ops genie <img width="1712" alt="image" src="https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7">
…#201923) ## Summary fixes elastic#168681 Fix to handle ops genie as default connector !! Tested by creating a trail account in ops genie <img width="1712" alt="image" src="https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7">
…#201923) ## Summary fixes elastic#168681 Fix to handle ops genie as default connector !! Tested by creating a trail account in ops genie <img width="1712" alt="image" src="https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7">
Summary
fixes #168681
Fix to handle ops genie as default connector !!
Tested by creating a trail account in ops genie