Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Fix to handle ops genie as default connector !! #201923

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Nov 27, 2024

Summary

fixes #168681

Fix to handle ops genie as default connector !!

Tested by creating a trail account in ops genie

image

@shahzad31 shahzad31 requested review from a team as code owners November 27, 2024 09:55
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Nov 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 added release_note:fix backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development labels Nov 27, 2024
@@ -128,6 +131,14 @@ export function populateAlertActions({
actions.push(recoveredAction);
}
break;
case OPSGENIE_ACTION_ID:
// @ts-expect-error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to avoid @ts-expect-error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am clueless on how to handle it.

Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Opsgenie connector, worked as expected.

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseOps changes LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 2, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 4a8aa64
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-201923-4a8aa6418342

Metrics [docs]

✅ unchanged

History

@shahzad31 shahzad31 merged commit a674b9d into elastic:main Dec 2, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12126428120

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
…#201923)

## Summary

fixes elastic#168681

Fix to handle ops genie as default connector !!

Tested by creating a trail account in ops genie

<img width="1712" alt="image"
src="https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7">

(cherry picked from commit a674b9d)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
…#201923)

## Summary

fixes elastic#168681

Fix to handle ops genie as default connector !!

Tested by creating a trail account in ops genie

<img width="1712" alt="image"
src="https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7">

(cherry picked from commit a674b9d)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
…#201923)

## Summary

fixes elastic#168681

Fix to handle ops genie as default connector !!

Tested by creating a trail account in ops genie

<img width="1712" alt="image"
src="https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7">

(cherry picked from commit a674b9d)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.15 Backport failed because of merge conflicts
8.16
8.17
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 201923

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 2, 2024
…201923) (#202571)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Synthetics] Fix to handle ops genie as default connector !!
(#201923)](#201923)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-12-02T19:20:26Z","message":"[Synthetics]
Fix to handle ops genie as default connector !! (#201923)\n\n##
Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops
genie as default connector !!\r\n\r\nTested by creating a trail account
in ops genie \r\n\r\n<img width=\"1712\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics]
Fix to handle ops genie as default connector
!!","number":201923,"url":"https://github.com/elastic/kibana/pull/201923","mergeCommit":{"message":"[Synthetics]
Fix to handle ops genie as default connector !! (#201923)\n\n##
Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops
genie as default connector !!\r\n\r\nTested by creating a trail account
in ops genie \r\n\r\n<img width=\"1712\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201923","number":201923,"mergeCommit":{"message":"[Synthetics]
Fix to handle ops genie as default connector !! (#201923)\n\n##
Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops
genie as default connector !!\r\n\r\nTested by creating a trail account
in ops genie \r\n\r\n<img width=\"1712\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
kibanamachine added a commit that referenced this pull request Dec 2, 2024
…201923) (#202572)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Synthetics] Fix to handle ops genie as default connector !!
(#201923)](#201923)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-12-02T19:20:26Z","message":"[Synthetics]
Fix to handle ops genie as default connector !! (#201923)\n\n##
Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops
genie as default connector !!\r\n\r\nTested by creating a trail account
in ops genie \r\n\r\n<img width=\"1712\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics]
Fix to handle ops genie as default connector
!!","number":201923,"url":"https://github.com/elastic/kibana/pull/201923","mergeCommit":{"message":"[Synthetics]
Fix to handle ops genie as default connector !! (#201923)\n\n##
Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops
genie as default connector !!\r\n\r\nTested by creating a trail account
in ops genie \r\n\r\n<img width=\"1712\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201923","number":201923,"mergeCommit":{"message":"[Synthetics]
Fix to handle ops genie as default connector !! (#201923)\n\n##
Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops
genie as default connector !!\r\n\r\nTested by creating a trail account
in ops genie \r\n\r\n<img width=\"1712\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
@kibanamachine kibanamachine added v8.17.0 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Dec 2, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Dec 5, 2024
…201923) (#202573)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] Fix to handle ops genie as default connector !!
(#201923)](#201923)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-12-02T19:20:26Z","message":"[Synthetics]
Fix to handle ops genie as default connector !! (#201923)\n\n##
Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops
genie as default connector !!\r\n\r\nTested by creating a trail account
in ops genie \r\n\r\n<img width=\"1712\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics]
Fix to handle ops genie as default connector
!!","number":201923,"url":"https://github.com/elastic/kibana/pull/201923","mergeCommit":{"message":"[Synthetics]
Fix to handle ops genie as default connector !! (#201923)\n\n##
Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops
genie as default connector !!\r\n\r\nTested by creating a trail account
in ops genie \r\n\r\n<img width=\"1712\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201923","number":201923,"mergeCommit":{"message":"[Synthetics]
Fix to handle ops genie as default connector !! (#201923)\n\n##
Summary\r\n\r\nfixes
https://github.com/elastic/kibana/issues/168681\r\n\r\nFix to handle ops
genie as default connector !!\r\n\r\nTested by creating a trail account
in ops genie \r\n\r\n<img width=\"1712\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7\">","sha":"a674b9d043faf58494feda039bb2a563c9f4d661"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
@kibanamachine kibanamachine added v8.18.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Dec 5, 2024
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Dec 5, 2024
…#201923)

## Summary

fixes elastic#168681

Fix to handle ops genie as default connector !!

Tested by creating a trail account in ops genie 

<img width="1712" alt="image"
src="https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7">
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
…#201923)

## Summary

fixes elastic#168681

Fix to handle ops genie as default connector !!

Tested by creating a trail account in ops genie 

<img width="1712" alt="image"
src="https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7">
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…#201923)

## Summary

fixes elastic#168681

Fix to handle ops genie as default connector !!

Tested by creating a trail account in ops genie 

<img width="1712" alt="image"
src="https://github.com/user-attachments/assets/ec768758-0fd3-4e3e-bb16-2bc11f10f6b7">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development ci:project-deploy-observability Create an Observability project release_note:fix Team:obs-ux-management Observability Management User Experience Team v8.16.2 v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using OpsGenie Connector as Default Connector in Synthetics Alerting does not work
5 participants