Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ownership] Add quick check to prevent test files from being added without an owner #201979

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Nov 27, 2024

Summary

Add quick check to prevent test files from being added without an owner

Resolves: #192979

@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Nov 27, 2024
@wayneseymour wayneseymour requested a review from pheyos November 27, 2024 13:23
@wayneseymour wayneseymour self-assigned this Nov 27, 2024
@wayneseymour wayneseymour marked this pull request as ready for review November 29, 2024 12:25
@wayneseymour wayneseymour requested a review from a team as a code owner November 29, 2024 12:25
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @wayneseymour

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delanni delanni merged commit 10f5056 into elastic:main Dec 2, 2024
7 of 9 checks passed
@delanni
Copy link
Contributor

delanni commented Dec 2, 2024

Admin-merged, because the CI check already ran green, and the test suites don't provide much extra value

@wayneseymour wayneseymour deleted the testfiles-ownership-quick-check branch December 5, 2024 09:51
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
…thout an owner (elastic#201979)

## Summary

Add quick check to prevent test files from being added without an owner

Resolves: elastic#192979

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…thout an owner (elastic#201979)

## Summary

Add quick check to prevent test files from being added without an owner

Resolves: elastic#192979

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FTR][No Missing Owners for Test Files] Enable Code Owners Check on PR's
5 participants