[Security Solution] Fixes exception item comment validation on newline chars `\n` #202063

dhurley14 · 2024-11-27T20:12:38Z

Summary

Fixes: #201820

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

…nt-regex

…bana into fix-exception-comment-regex

nicpenning · 2024-12-04T12:28:47Z

👀

elasticmachine · 2024-12-04T12:46:16Z

Pinging @elastic/security-detections-response (Team:Detections and Resp)

janmonschke

Threat Hunting changes lgtm

dhurley14 · 2024-12-09T21:31:05Z

/ci

dhurley14 · 2024-12-09T21:45:30Z

CI failing due to this test: #203477

maximpn

@dhurley14 Thanks for addressing the comments 🙏

It looks good to go. @xcrzx do you have any objections?

nkhristinin

LGTM!

xcrzx

LGTM 👍

elasticmachine · 2024-12-10T14:26:47Z

💚 Build Succeeded

Buildkite Build
Commit: 560a533

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`integrationAssistant`	472	473	+1
`inventory`	256	257	+1
`securitySolution`	6348	6349	+1
total			+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/zod-helpers`	10	13	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	14.7MB	14.7MB	+1.1KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/zod-helpers`	20	23	+3

History

💔 Build #258521 failed 624c48c
💔 Build #258479 failed 624c48c
💔 Build #258420 failed 854b593
💔 Build #257216 failed f295332
💚 Build #256982 succeeded 09b275e
💚 Build #256888 succeeded a8f3428

cc @dhurley14

pmuellr · 2024-12-10T16:59:02Z

This appears to be a change to some SIEM rule type parameters, where the schema is now a little more lenient? Basically, the schema bits "pattern": "^(?! *$).+$" have been removed from some parameter properties.

In terms of serverless BWC/ZDT, this seems "safe" from an upgrade POV (making this less lenient can be a problem). But roll back? What happens if this updated is deployed for some amount of time, and then we determine we need to roll back to the previous code. I'm guessing they would see the same errors they saw before, which is obviously fine.

Thought I'd double-check those assumptions before approving.

dhurley14 · 2024-12-10T20:02:18Z

@pmuellr great questions!

This appears to be a change to some SIEM rule type parameters, where the schema is now a little more lenient?

Yes we have a better system in place for ensuring strings passed to certain parameters are not empty strings and do not fail validation when newline chars are included. This same regex was used in places where free-text fields were not used, however the team felt it better to replace all of the instances of the regex with this new trim function. Which I suppose could be considered more lenient!

What happens if this updated is deployed for some amount of time, and then we determine we need to roll back to the previous code

Great question - If these changes are deployed and then subsequently rolled back, we would enter into a similar situation as an upgrade from 8.15 to 8.16 where customers who had previously added newline chars would have errors in the UI, specifically in the exceptions UI.

pmuellr · 2024-12-10T20:36:03Z

What happens if this updated is deployed for some amount of time, and then we determine we need to roll back to the previous code

If these changes are deployed and then subsequently rolled back, we would enter into a similar situation as an upgrade from 8.15 to 8.16 where customers who had previously added newline chars would have errors in the UI, specifically in the exceptions UI.

Ya, so if you go back to the buggy release, you'll see the bugs. Hard to imagine that's fixable, really, even with an "intermediate" release - or it would not be easy (probably involving some backward-compatible migration). Seems fine to me.

thx!

pmuellr

ResponseOps changes LGTM, based on comments posted.

kibanamachine · 2024-12-10T22:19:50Z

Starting backport for target branches: 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12265712482

kibanamachine · 2024-12-10T22:25:22Z

💔 All backports failed

Status	Branch	Result
❌	8.16	Backport failed because of merge conflicts You might need to backport the following PRs to 8.16: - [Security Assistant] Fix animation border color of security AI assistant (#202319) - [Infra] Fix call to service api (#203451)
❌	8.17	Backport failed because of merge conflicts
❌	8.x	Backport failed because of merge conflicts You might need to backport the following PRs to 8.x: - remove redux tools from presentation_utils plugin (#197891) - [Security Solution][Expandable flyout] Introducing Flyout history in document flyout (#184970) - Support incoming Preconfigured Endpoints (#203473) - [dashboard] remove legacy embeddable client migrations (#203669) - Upgrade express 4.21.1→ 4.21.2 (#203504) - [Infra][ObsUX] Hosts & Container Logs only overview (#202992) - [SecuritySolution] Fix serviceEntityStoreEnabled experimental flag initial value (#203573) - [Security Assistant] Fix animation border color of security AI assistant (#202319)

Manual backport

To create the backport manually run:

node scripts/backport --pr 202063

Questions ?

Please refer to the Backport tool documentation

…e chars `\n` (elastic#202063) ## Summary Fixes: elastic#201820 Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 35aeac1) # Conflicts: # oas_docs/output/kibana.serverless.yaml

…e chars `\n` (elastic#202063) ## Summary Fixes: elastic#201820 Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 35aeac1) # Conflicts: # oas_docs/output/kibana.serverless.yaml # x-pack/plugins/security_solution/common/siem_migrations/model/common.schema.yaml

dhurley14 · 2024-12-10T23:31:17Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x
✅	8.17
✅	8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…e chars `\n` (elastic#202063) ## Summary Fixes: elastic#201820 Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 35aeac1) # Conflicts: # oas_docs/output/kibana.serverless.yaml # x-pack/plugins/security_solution/common/siem_migrations/model/common.gen.ts # x-pack/plugins/security_solution/common/siem_migrations/model/common.schema.yaml

… newline chars `\n` (#202063) (#203709) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution] Fixes exception item comment validation on newline chars `\n` (#202063)](#202063)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)

…newline chars `\n` (#202063) (#203707) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Fixes exception item comment validation on newline chars `\n` (#202063)](#202063)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)

…e chars `\n` (elastic#202063) ## Summary Fixes: elastic#201820 Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

dhurley14 and others added 7 commits November 27, 2024 15:11

initial tests and changes

7e809bd

provide custom validation for non empty strings in openapi and zod

376ae06

[CI] Auto-commit changed files from 'node scripts/notice'

416dcd3

[CI] Auto-commit changed files from 'yarn openapi:bundle'

8c6ec80

Merge remote-tracking branch 'upstream/main' into fix-exception-comme…

70042e1

…nt-regex

Merge branch 'fix-exception-comment-regex' of github.com:dhurley14/ki…

cd92dc6

…bana into fix-exception-comment-regex

[CI] Auto-commit changed files from 'make api-docs'

1881b1b

dhurley14 self-assigned this Dec 4, 2024

dhurley14 added the backport:version Backport to applied version labels label Dec 4, 2024

cleanup

a8f3428

dhurley14 marked this pull request as ready for review December 4, 2024 12:46

dhurley14 requested review from a team as code owners December 4, 2024 12:46

dhurley14 requested review from nkhristinin and xcrzx December 4, 2024 12:46

dhurley14 requested review from maximpn and marshallmain December 4, 2024 12:48

patrykkopycinski approved these changes Dec 9, 2024

View reviewed changes

dhurley14 requested review from maximpn and xcrzx December 9, 2024 17:35

janmonschke approved these changes Dec 9, 2024

View reviewed changes

Merge branch 'main' into fix-exception-comment-regex

624c48c

maximpn approved these changes Dec 10, 2024

View reviewed changes

Merge branch 'main' into fix-exception-comment-regex

560a533

nkhristinin approved these changes Dec 10, 2024

View reviewed changes

xcrzx approved these changes Dec 10, 2024

View reviewed changes

pmuellr approved these changes Dec 10, 2024

View reviewed changes

dhurley14 merged commit 35aeac1 into elastic:main Dec 10, 2024
8 checks passed

dhurley14 mentioned this pull request Dec 10, 2024

[8.x] [Security Solution] Fixes exception item comment validation on newline chars \n (#202063) #203707

Merged

dhurley14 mentioned this pull request Dec 10, 2024

[8.17] [Security Solution] Fixes exception item comment validation on newline chars \n (#202063) #203708

Open

dhurley14 mentioned this pull request Dec 10, 2024

[8.16] [Security Solution] Fixes exception item comment validation on newline chars \n (#202063) #203709

Merged

kibanamachine mentioned this pull request Dec 12, 2024

[DOCS] Adds conceptual content to API docs #202305

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Fixes exception item comment validation on newline chars `\n` #202063

[Security Solution] Fixes exception item comment validation on newline chars `\n` #202063

dhurley14 commented Nov 27, 2024 •

edited by kibanamachine

Loading

nicpenning commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

janmonschke left a comment

dhurley14 commented Dec 9, 2024

dhurley14 commented Dec 9, 2024

maximpn left a comment

nkhristinin left a comment

xcrzx left a comment

elasticmachine commented Dec 10, 2024

API count

pmuellr commented Dec 10, 2024

dhurley14 commented Dec 10, 2024

pmuellr commented Dec 10, 2024

pmuellr left a comment

kibanamachine commented Dec 10, 2024

kibanamachine commented Dec 10, 2024

dhurley14 commented Dec 10, 2024

[Security Solution] Fixes exception item comment validation on newline chars \n #202063

[Security Solution] Fixes exception item comment validation on newline chars \n #202063

Conversation

dhurley14 commented Nov 27, 2024 • edited by kibanamachine Loading

Summary

Checklist

nicpenning commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

janmonschke left a comment

Choose a reason for hiding this comment

dhurley14 commented Dec 9, 2024

dhurley14 commented Dec 9, 2024

maximpn left a comment

Choose a reason for hiding this comment

nkhristinin left a comment

Choose a reason for hiding this comment

xcrzx left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 10, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

API count

History

pmuellr commented Dec 10, 2024

dhurley14 commented Dec 10, 2024

pmuellr commented Dec 10, 2024

pmuellr left a comment

Choose a reason for hiding this comment

kibanamachine commented Dec 10, 2024

kibanamachine commented Dec 10, 2024

💔 All backports failed

Manual backport

Questions ?

dhurley14 commented Dec 10, 2024

💚 All backports created successfully

Questions ?

[Security Solution] Fixes exception item comment validation on newline chars `\n` #202063

[Security Solution] Fixes exception item comment validation on newline chars `\n` #202063

dhurley14 commented Nov 27, 2024 •

edited by kibanamachine

Loading