Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detection Engine] deprecates siem signals migration APIs #202662

Merged
merged 12 commits into from
Dec 10, 2024
Merged

[Security Solution][Detection Engine] deprecates siem signals migration APIs #202662

merged 12 commits into from
Dec 10, 2024
+76 −12

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Dec 3, 2024 •
edited by kibanamachine
Loading

Summary

How to test deprecated APIs?

  1. Run API https://www.elastic.co/guide/en/security/current/signals-migration-api.html
  2. Observe warning deprecation on Kibana Upgrade page
Screenshot 2024-12-03 at 10 43 59

@vitaliidm vitaliidm self-assigned this Dec 3, 2024
@vitaliidm vitaliidm added release_note:deprecation Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 3, 2024
@vitaliidm vitaliidm marked this pull request as ready for review December 4, 2024 12:03
@vitaliidm vitaliidm requested review from a team as code owners December 4, 2024 12:03
@vitaliidm vitaliidm requested a review from rylnd December 4, 2024 12:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@vitaliidm vitaliidm requested a review from maximpn December 4, 2024 12:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

maximpn
maximpn approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested locally. As expected after sending requests to deprecated routes warnings appear in Upgrade Assistant.

rylnd
rylnd approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vitaliidm !

@vitaliidm vitaliidm mentioned this pull request Dec 9, 2024
Open
4 tasks
georgewallace
georgewallace approved these changes Dec 9, 2024
View reviewed changes
Copy link

@georgewallace georgewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes and doc links look good.

@vitaliidm vitaliidm enabled auto-merge (squash) December 10, 2024 10:29
@vitaliidm vitaliidm merged commit 3d46ead into elastic:main Dec 10, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12255606546

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 93.1KB 93.2KB +53.0B
lists 145.5KB 145.6KB +53.0B
total +106.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 450.6KB 450.7KB +53.0B

History

cc @vitaliidm

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 10, 2024
@vitaliidm
[Security Solution][Detection Engine] deprecates siem signals migrati…
9f5255c 
…on APIs (elastic#202662)

## Summary

 - addresses part of elastic#195523
- deprecates
https://www.elastic.co/guide/en/security/current/signals-migration-api.html
APIs according to internal 9.x readiness
[guideline](https://docs.google.com/document/d/1W7csjn6QYjrBjmbXMzSz_JUD4KcmWz8jTTtAWFwgUJM/edit?tab=t.0#heading=h.tui2zvb9gca6)

#### How to test deprecated APIs?

1. Run API
https://www.elastic.co/guide/en/security/current/signals-migration-api.html
2. Observe warning deprecation on Kibana Upgrade page

<img width="2540" alt="Screenshot 2024-12-03 at 10 43 59"
src="https://github.com/user-attachments/assets/24fcebb9-2d31-4ca3-a0dc-4ed7861d26a2">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3d46ead)
@kibanamachine kibanamachine mentioned this pull request Dec 10, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 10, 2024
@kibanamachine @vitaliidm
[8.x] [Security Solution][Detection Engine] deprecates siem signals m…
467f7f1 
…igration APIs (#202662) (#203549)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Detection Engine] deprecates siem signals
migration APIs (#202662)](#202662)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Vitalii
Dmyterko","email":"92328789+vitaliidm@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-10T11:58:08Z","message":"[Security
Solution][Detection Engine] deprecates siem signals migration APIs
(#202662)\n\n## Summary\r\n\r\n - addresses part of
https://github.com/elastic/kibana/issues/195523\r\n-
deprecates\r\nhttps://www.elastic.co/guide/en/security/current/signals-migration-api.html\r\nAPIs
according to internal 9.x
readiness\r\n[guideline](https://docs.google.com/document/d/1W7csjn6QYjrBjmbXMzSz_JUD4KcmWz8jTTtAWFwgUJM/edit?tab=t.0#heading=h.tui2zvb9gca6)\r\n
\r\n#### How to test deprecated APIs?\r\n\r\n1. Run
API\r\nhttps://www.elastic.co/guide/en/security/current/signals-migration-api.html\r\n2.
Observe warning deprecation on Kibana Upgrade page\r\n\r\n<img
width=\"2540\" alt=\"Screenshot 2024-12-03 at 10 43
59\"\r\nsrc=\"https://github.com/user-attachments/assets/24fcebb9-2d31-4ca3-a0dc-4ed7861d26a2\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3d46eadace572cbcfb95611224b819e2e67ed006","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:deprecation","v9.0.0","Team:Detections
and Resp","Team: SecuritySolution","backport:prev-minor","Team:Detection
Engine"],"title":"[Security Solution][Detection Engine] deprecates siem
signals migration
APIs","number":202662,"url":"https://github.com/elastic/kibana/pull/202662","mergeCommit":{"message":"[Security
Solution][Detection Engine] deprecates siem signals migration APIs
(#202662)\n\n## Summary\r\n\r\n - addresses part of
https://github.com/elastic/kibana/issues/195523\r\n-
deprecates\r\nhttps://www.elastic.co/guide/en/security/current/signals-migration-api.html\r\nAPIs
according to internal 9.x
readiness\r\n[guideline](https://docs.google.com/document/d/1W7csjn6QYjrBjmbXMzSz_JUD4KcmWz8jTTtAWFwgUJM/edit?tab=t.0#heading=h.tui2zvb9gca6)\r\n
\r\n#### How to test deprecated APIs?\r\n\r\n1. Run
API\r\nhttps://www.elastic.co/guide/en/security/current/signals-migration-api.html\r\n2.
Observe warning deprecation on Kibana Upgrade page\r\n\r\n<img
width=\"2540\" alt=\"Screenshot 2024-12-03 at 10 43
59\"\r\nsrc=\"https://github.com/user-attachments/assets/24fcebb9-2d31-4ca3-a0dc-4ed7861d26a2\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3d46eadace572cbcfb95611224b819e2e67ed006"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202662","number":202662,"mergeCommit":{"message":"[Security
Solution][Detection Engine] deprecates siem signals migration APIs
(#202662)\n\n## Summary\r\n\r\n - addresses part of
https://github.com/elastic/kibana/issues/195523\r\n-
deprecates\r\nhttps://www.elastic.co/guide/en/security/current/signals-migration-api.html\r\nAPIs
according to internal 9.x
readiness\r\n[guideline](https://docs.google.com/document/d/1W7csjn6QYjrBjmbXMzSz_JUD4KcmWz8jTTtAWFwgUJM/edit?tab=t.0#heading=h.tui2zvb9gca6)\r\n
\r\n#### How to test deprecated APIs?\r\n\r\n1. Run
API\r\nhttps://www.elastic.co/guide/en/security/current/signals-migration-api.html\r\n2.
Observe warning deprecation on Kibana Upgrade page\r\n\r\n<img
width=\"2540\" alt=\"Screenshot 2024-12-03 at 10 43
59\"\r\nsrc=\"https://github.com/user-attachments/assets/24fcebb9-2d31-4ca3-a0dc-4ed7861d26a2\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3d46eadace572cbcfb95611224b819e2e67ed006"}}]}]
BACKPORT-->

Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@vitaliidm @kibanamachine @CAWilson94
[Security Solution][Detection Engine] deprecates siem signals migrati…
f257939 
…on APIs (elastic#202662)

## Summary

 - addresses part of elastic#195523
- deprecates
https://www.elastic.co/guide/en/security/current/signals-migration-api.html
APIs according to internal 9.x readiness
[guideline](https://docs.google.com/document/d/1W7csjn6QYjrBjmbXMzSz_JUD4KcmWz8jTTtAWFwgUJM/edit?tab=t.0#heading=h.tui2zvb9gca6)
 
#### How to test deprecated APIs?

1. Run API
https://www.elastic.co/guide/en/security/current/signals-migration-api.html
2. Observe warning deprecation on Kibana Upgrade page

<img width="2540" alt="Screenshot 2024-12-03 at 10 43 59"
src="https://github.com/user-attachments/assets/24fcebb9-2d31-4ca3-a0dc-4ed7861d26a2">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgewallace georgewallace georgewallace approved these changes

@maximpn maximpn maximpn approved these changes

@rylnd rylnd rylnd approved these changes

Assignees

@vitaliidm vitaliidm

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:deprecation Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vitaliidm @elasticmachine @kibanamachine @rylnd @maximpn @georgewallace