[Entity Analytics][Entity Store] Clear error on second entity engine init API call #202903
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
added
release_note:fix
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
tiansivive
approved these changes
Dec 4, 2024
|
Starting backport for target branches: 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12161424132 |
💚 Build Succeeded
Metrics [docs]
cc @hop-dev |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 4, 2024
…init API call (elastic#202903) ## Summary If the first call to init an entity engine fails, we add the `error` property to the engine status, if we then call the API a second time this error was not being wiped. This PR resets the error on the second call. ### Test steps - Do not visit the UI of a kibana so that the security default data view does not exist - Call the init API for an entity engine e,g host - Call the engine status API, notice the status has an error - Visait the security solution UI and wait for the data view to be created - Re-call the init API and notice the error has gone (cherry picked from commit 9997dab)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 4, 2024
…init API call (elastic#202903) ## Summary If the first call to init an entity engine fails, we add the `error` property to the engine status, if we then call the API a second time this error was not being wiped. This PR resets the error on the second call. ### Test steps - Do not visit the UI of a kibana so that the security default data view does not exist - Call the init API for an entity engine e,g host - Call the engine status API, notice the status has an error - Visait the security solution UI and wait for the data view to be created - Re-call the init API and notice the error has gone (cherry picked from commit 9997dab)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 4, 2024
…engine init API call (#202903) (#202935) # Backport This will backport the following commits from `main` to `8.17`: - [[Entity Analytics][Entity Store] Clear error on second entity engine init API call (#202903)](#202903) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"mark.hopkin@elastic.co"},"sourceCommit":{"committedDate":"2024-12-04T14:06:56Z","message":"[Entity Analytics][Entity Store] Clear error on second entity engine init API call (#202903)\n\n## Summary\n\nIf the first call to init an entity engine fails, we add the `error`\nproperty to the engine status, if we then call the API a second time\nthis error was not being wiped. This PR resets the error on the second\ncall.\n\n### Test steps\n\n- Do not visit the UI of a kibana so that the security default data view\ndoes not exist\n- Call the init API for an entity engine e,g host\n- Call the engine status API, notice the status has an error\n- Visait the security solution UI and wait for the data view to be\ncreated\n- Re-call the init API and notice the error has gone","sha":"9997dabf90f3dd36c0577a8d6f6e10dd5dc88054","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team: SecuritySolution","Team:Entity Analytics","backport:version","v8.17.0","v8.18.0"],"title":"[Entity Analytics][Entity Store] Clear error on second entity engine init API call","number":202903,"url":"https://github.com/elastic/kibana/pull/202903","mergeCommit":{"message":"[Entity Analytics][Entity Store] Clear error on second entity engine init API call (#202903)\n\n## Summary\n\nIf the first call to init an entity engine fails, we add the `error`\nproperty to the engine status, if we then call the API a second time\nthis error was not being wiped. This PR resets the error on the second\ncall.\n\n### Test steps\n\n- Do not visit the UI of a kibana so that the security default data view\ndoes not exist\n- Call the init API for an entity engine e,g host\n- Call the engine status API, notice the status has an error\n- Visait the security solution UI and wait for the data view to be\ncreated\n- Re-call the init API and notice the error has gone","sha":"9997dabf90f3dd36c0577a8d6f6e10dd5dc88054"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202903","number":202903,"mergeCommit":{"message":"[Entity Analytics][Entity Store] Clear error on second entity engine init API call (#202903)\n\n## Summary\n\nIf the first call to init an entity engine fails, we add the `error`\nproperty to the engine status, if we then call the API a second time\nthis error was not being wiped. This PR resets the error on the second\ncall.\n\n### Test steps\n\n- Do not visit the UI of a kibana so that the security default data view\ndoes not exist\n- Call the init API for an entity engine e,g host\n- Call the engine status API, notice the status has an error\n- Visait the security solution UI and wait for the data view to be\ncreated\n- Re-call the init API and notice the error has gone","sha":"9997dabf90f3dd36c0577a8d6f6e10dd5dc88054"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Dec 4, 2024
…ngine init API call (#202903) (#202936) # Backport This will backport the following commits from `main` to `8.x`: - [[Entity Analytics][Entity Store] Clear error on second entity engine init API call (#202903)](#202903) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"mark.hopkin@elastic.co"},"sourceCommit":{"committedDate":"2024-12-04T14:06:56Z","message":"[Entity Analytics][Entity Store] Clear error on second entity engine init API call (#202903)\n\n## Summary\n\nIf the first call to init an entity engine fails, we add the `error`\nproperty to the engine status, if we then call the API a second time\nthis error was not being wiped. This PR resets the error on the second\ncall.\n\n### Test steps\n\n- Do not visit the UI of a kibana so that the security default data view\ndoes not exist\n- Call the init API for an entity engine e,g host\n- Call the engine status API, notice the status has an error\n- Visait the security solution UI and wait for the data view to be\ncreated\n- Re-call the init API and notice the error has gone","sha":"9997dabf90f3dd36c0577a8d6f6e10dd5dc88054","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team: SecuritySolution","Team:Entity Analytics","backport:version","v8.17.0","v8.18.0"],"title":"[Entity Analytics][Entity Store] Clear error on second entity engine init API call","number":202903,"url":"https://github.com/elastic/kibana/pull/202903","mergeCommit":{"message":"[Entity Analytics][Entity Store] Clear error on second entity engine init API call (#202903)\n\n## Summary\n\nIf the first call to init an entity engine fails, we add the `error`\nproperty to the engine status, if we then call the API a second time\nthis error was not being wiped. This PR resets the error on the second\ncall.\n\n### Test steps\n\n- Do not visit the UI of a kibana so that the security default data view\ndoes not exist\n- Call the init API for an entity engine e,g host\n- Call the engine status API, notice the status has an error\n- Visait the security solution UI and wait for the data view to be\ncreated\n- Re-call the init API and notice the error has gone","sha":"9997dabf90f3dd36c0577a8d6f6e10dd5dc88054"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202903","number":202903,"mergeCommit":{"message":"[Entity Analytics][Entity Store] Clear error on second entity engine init API call (#202903)\n\n## Summary\n\nIf the first call to init an entity engine fails, we add the `error`\nproperty to the engine status, if we then call the API a second time\nthis error was not being wiped. This PR resets the error on the second\ncall.\n\n### Test steps\n\n- Do not visit the UI of a kibana so that the security default data view\ndoes not exist\n- Call the init API for an entity engine e,g host\n- Call the engine status API, notice the status has an error\n- Visait the security solution UI and wait for the data view to be\ncreated\n- Re-call the init API and notice the error has gone","sha":"9997dabf90f3dd36c0577a8d6f6e10dd5dc88054"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
…init API call (elastic#202903) ## Summary If the first call to init an entity engine fails, we add the `error` property to the engine status, if we then call the API a second time this error was not being wiped. This PR resets the error on the second call. ### Test steps - Do not visit the UI of a kibana so that the security default data view does not exist - Call the init API for an entity engine e,g host - Call the engine status API, notice the status has an error - Visait the security solution UI and wait for the data view to be created - Re-call the init API and notice the error has gone
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
…init API call (elastic#202903) ## Summary If the first call to init an entity engine fails, we add the `error` property to the engine status, if we then call the API a second time this error was not being wiped. This PR resets the error on the second call. ### Test steps - Do not visit the UI of a kibana so that the security default data view does not exist - Call the init API for an entity engine e,g host - Call the engine status API, notice the status has an error - Visait the security solution UI and wait for the data view to be created - Re-call the init API and notice the error has gone
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
…init API call (elastic#202903) ## Summary If the first call to init an entity engine fails, we add the `error` property to the engine status, if we then call the API a second time this error was not being wiped. This PR resets the error on the second call. ### Test steps - Do not visit the UI of a kibana so that the security default data view does not exist - Call the init API for an entity engine e,g host - Call the engine status API, notice the status has an error - Visait the security solution UI and wait for the data view to be created - Re-call the init API and notice the error has gone
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…init API call (elastic#202903) ## Summary If the first call to init an entity engine fails, we add the `error` property to the engine status, if we then call the API a second time this error was not being wiped. This PR resets the error on the second call. ### Test steps - Do not visit the UI of a kibana so that the security default data view does not exist - Call the init API for an entity engine e,g host - Call the engine status API, notice the status has an error - Visait the security solution UI and wait for the data view to be created - Re-call the init API and notice the error has gone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the first call to init an entity engine fails, we add the
errorproperty to the engine status, if we then call the API a second time this error was not being wiped. This PR resets the error on the second call.Test steps