Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs settings: Remove sample data from default #202981

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Logs settings: Remove sample data from default #202981

merged 1 commit into from
Dec 4, 2024

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Dec 4, 2024 •
edited by kibanamachine
Loading

Closes #195867

@flash1293 flash1293 added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-logs Observability Logs User Experience Team v8.18.0 labels Dec 4, 2024
@flash1293 flash1293 requested a review from a team as a code owner December 4, 2024 16:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 4, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: d6eb2c1
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202981-d6eb2c17eafd

Metrics [docs]

✅ unchanged

History

yngrdyn
yngrdyn approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one 🚀

@flash1293 flash1293 merged commit a6f5017 into elastic:main Dec 4, 2024
21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12166965123

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 4, 2024
@flash1293
Logs settings: Remove sample data from default (elastic#202981)
90bd200 
Closes elastic#195867

(cherry picked from commit a6f5017)
@kibanamachine kibanamachine mentioned this pull request Dec 4, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 6, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Dec 7, 2024
@kibanamachine @flash1293
[8.x] Logs settings: Remove sample data from default (#202981) (#203010)
cae5444 
# Backport

This will backport the following commits from `main` to `8.x`:
- [Logs settings: Remove sample data from default
(#202981)](#202981)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Joe
Reuter","email":"johannes.reuter@elastic.co"},"sourceCommit":{"committedDate":"2024-12-04T19:33:18Z","message":"Logs
settings: Remove sample data from default (#202981)\n\nCloses
https://github.com/elastic/kibana/issues/195867","sha":"a6f5017623874d858bd3aa3567764599eedeef0f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","v8.18.0"],"title":"Logs
settings: Remove sample data from
default","number":202981,"url":"https://github.com/elastic/kibana/pull/202981","mergeCommit":{"message":"Logs
settings: Remove sample data from default (#202981)\n\nCloses
https://github.com/elastic/kibana/issues/195867","sha":"a6f5017623874d858bd3aa3567764599eedeef0f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202981","number":202981,"mergeCommit":{"message":"Logs
settings: Remove sample data from default (#202981)\n\nCloses
https://github.com/elastic/kibana/issues/195867","sha":"a6f5017623874d858bd3aa3567764599eedeef0f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 7, 2024
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@flash1293 @SoniaSanzV
Logs settings: Remove sample data from default (elastic#202981)
055780b 
Closes elastic#195867
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
@flash1293 @SoniaSanzV
Logs settings: Remove sample data from default (elastic#202981)
a0b66de 
Closes elastic#195867
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@flash1293 @CAWilson94
Logs settings: Remove sample data from default (elastic#202981)
fec065a 
Closes elastic#195867
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
@flash1293 @Samiul-TheSoccerFan
Logs settings: Remove sample data from default (elastic#202981)
ff061eb 
Closes elastic#195867
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@flash1293 @CAWilson94
Logs settings: Remove sample data from default (elastic#202981)
310f092 
Closes elastic#195867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngrdyn yngrdyn yngrdyn approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove sample data index from default centralized logs setting
4 participants
@flash1293 @elasticmachine @kibanamachine @yngrdyn