Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [KibanaRootContextProvider] destructure the params to KibanaEuiProvider (#203303) #203347

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…er (elastic#203303)

## Summary

Addresses:
elastic#202606 (comment)

This discards the
> unused portions of core, before adding them to the context value, but
still allow people to pass the entire construct if we were to need
something else

cc @clintandrewhall

----

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

**none**

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

**none**

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 79e7316)
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 6, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #73 / Agent policies fleet_agent_policies POST /api/fleet/agent_policies should create .fleet-policies document with inputs
  • [job] [logs] FTR Configs #73 / Agent policies fleet_agent_policies POST /api/fleet/agent_policies should create .fleet-policies document with inputs

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 614.9KB 615.8KB +964.0B
alerting 98.3KB 98.6KB +257.0B
apm 3.5MB 3.5MB +384.0B
canvas 1.1MB 1.1MB +240.0B
cloudDataMigration 5.9KB 6.1KB +257.0B
cloudSecurityPosture 502.5KB 502.8KB +257.0B
controls 459.4KB 459.6KB +240.0B
crossClusterReplication 146.2KB 146.5KB +257.0B
dashboard 649.4KB 649.5KB +39.0B
dataQuality 28.2KB 28.5KB +257.0B
dataUsage 241.2KB 241.5KB +257.0B
dataViewEditor 49.4KB 49.4KB +1.0B
dataViewFieldEditor 177.8KB 177.9KB +39.0B
dataViewManagement 139.8KB 140.0KB +257.0B
dataVisualizer 613.8KB 614.8KB +1.0KB
devTools 7.8KB 8.0KB +257.0B
discover 812.9KB 813.1KB +240.0B
enterpriseSearch 2.6MB 2.6MB +145.0B
entityManagerApp 12.0KB 12.3KB +267.0B
eventAnnotationListing 231.5KB 231.8KB +257.0B
exploratoryView 182.8KB 183.0KB +240.0B
expressionGauge 21.9KB 21.9KB -1.0B
expressionHeatmap 26.8KB 26.8KB -1.0B
expressionMetricVis 5.2KB 5.2KB +39.0B
expressionPartitionVis 35.6KB 35.6KB +39.0B
expressionXY 127.8KB 127.8KB -9.0B
filesManagement 125.2KB 125.5KB +257.0B
graph 417.9KB 418.2KB +257.0B
grokdebugger 11.0KB 11.2KB +205.0B
home 151.9KB 152.2KB +267.0B
imageEmbeddable 69.0KB 69.5KB +441.0B
indexLifecycleManagement 165.8KB 166.1KB +267.0B
indexManagement 697.0KB 697.1KB +36.0B
infra 1.7MB 1.7MB +441.0B
inputControlVis 52.1KB 52.3KB +241.0B
inventory 233.8KB 234.1KB +257.0B
kibanaOverview 54.7KB 54.9KB +257.0B
lens 1.5MB 1.5MB +240.0B
licenseManagement 46.5KB 46.8KB +262.0B
links 52.6KB 53.0KB +480.0B
logstash 33.4KB 33.6KB +257.0B
management 48.3KB 48.5KB +257.0B
metricsDataAccess 99.5KB 99.7KB +240.0B
ml 4.7MB 4.7MB +2.2KB
monitoring 533.4KB 533.7KB +257.0B
observabilityLogsExplorer 147.5KB 147.7KB +240.0B
observabilityOnboarding 281.9KB 282.2KB +267.0B
osquery 1.0MB 1.0MB +12.0B
painlessLab 18.5KB 18.7KB +197.0B
profiling 406.1KB 406.3KB +257.0B
remoteClusters 79.2KB 79.4KB +257.0B
rollup 115.5KB 115.8KB +257.0B
savedObjectsManagement 86.6KB 86.9KB +257.0B
searchHomepage 54.8KB 55.0KB +240.0B
searchIndices 167.5KB 167.7KB +240.0B
searchInferenceEndpoints 72.3KB 72.5KB +240.0B
searchPlayground 162.8KB 163.0KB +237.0B
searchprofiler 48.8KB 49.1KB +257.0B
securitySolution 13.4MB 13.4MB +1.4KB
serverlessSearch 339.2KB 339.7KB +480.0B
share 4.2KB 4.2KB +39.0B
slo 836.7KB 837.7KB +1.0KB
snapshotRestore 262.7KB 262.9KB +257.0B
streamsApp 73.8KB 74.0KB +257.0B
synthetics 1.1MB 1.1MB +476.0B
timelines 32.8KB 33.0KB +201.0B
transform 475.1KB 475.3KB +240.0B
triggersActionsUi 1.7MB 1.7MB +2.6KB
uptime 468.3KB 468.5KB +238.0B
ux 168.0KB 168.3KB +267.0B
visDefaultEditor 95.3KB 95.3KB +1.0B
visTypeTimeseries 507.1KB 507.4KB +234.0B
visTypeVega 1.9MB 1.9MB +40.0B
visualizations 320.4KB 320.4KB +39.0B
watcher 166.2KB 166.5KB +257.0B
total +23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
advancedSettings 7.4KB 7.7KB +241.0B
banners 10.4KB 10.7KB +261.0B
cases 159.3KB 159.6KB +240.0B
cloudLinks 30.2KB 30.5KB +257.0B
console 38.4KB 38.6KB +238.0B
core 454.3KB 454.5KB +257.0B
dashboard 51.8KB 52.0KB +204.0B
dashboardEnhanced 17.9KB 18.1KB +255.0B
data 419.9KB 420.2KB +240.0B
dataViewEditor 13.5KB 13.8KB +241.0B
dataViewFieldEditor 26.8KB 27.0KB +204.0B
embeddable 72.6KB 72.9KB +257.0B
expressionGauge 16.3KB 16.5KB +257.0B
expressionHeatmap 17.2KB 17.4KB +257.0B
expressionLegacyMetricVis 12.5KB 12.7KB +204.0B
expressionMetricVis 16.9KB 17.1KB +204.0B
expressionPartitionVis 29.1KB 29.3KB +204.0B
expressionTagcloud 13.2KB 13.5KB +257.0B
expressionXY 42.0KB 42.2KB +257.0B
fleet 172.9KB 173.1KB +240.0B
globalSearchBar 29.8KB 30.0KB +204.0B
guidedOnboarding 29.6KB 29.8KB +200.0B
indexManagement 46.7KB 46.9KB +204.0B
ingestPipelines 17.5KB 17.7KB +246.0B
inspector 24.9KB 25.1KB +204.0B
interactiveSetup 59.7KB 60.0KB +259.0B
kibanaReact 39.7KB 40.0KB +267.0B
licensing 11.7KB 11.9KB +204.0B
maps 54.3KB 54.6KB +240.0B
mockIdpPlugin 10.7KB 10.9KB +240.0B
newsfeed 12.7KB 13.0KB +257.0B
observability 104.9KB 105.1KB +238.0B
osquery 46.9KB 47.2KB +242.0B
painlessLab 10.3KB 10.2KB -47.0B
presentationPanel 43.3KB 43.5KB +240.0B
reporting 52.7KB 52.9KB +240.0B
runtimeFields 13.9KB 14.1KB +204.0B
savedObjects 17.6KB 17.8KB +204.0B
savedObjectsTagging 22.6KB 22.8KB +241.0B
security 67.9KB 68.1KB +240.0B
serverless 14.1KB 14.3KB +267.0B
share 57.8KB 58.0KB +200.0B
spaces 34.0KB 34.2KB +241.0B
telemetry 24.8KB 25.1KB +257.0B
uiActions 24.0KB 24.2KB +200.0B
unifiedSearch 38.6KB 38.8KB +241.0B
upgradeAssistant 24.6KB 24.8KB +267.0B
visDefaultEditor 24.0KB 24.2KB +241.0B
visTypeMarkdown 9.7KB 9.9KB +256.0B
visTypeTable 19.2KB 19.4KB +204.0B
visTypeTimelion 13.4KB 13.7KB +257.0B
visTypeTimeseries 20.4KB 20.6KB +204.0B
visTypeVega 36.1KB 36.3KB +200.0B
visTypeVislib 15.3KB 15.6KB +241.0B
visualizations 70.9KB 71.1KB +204.0B
total +12.3KB

History

cc @tsullivan

@kibanamachine kibanamachine merged commit d624dd4 into elastic:8.x Dec 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants