Improve Saved object import functional test assertions #20409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
changed the title
💚 Build Succeeded |
💚 Build Succeeded |
chrisronline
approved these changes
Jul 3, 2018
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jul 3, 2018
* disable broken functional tests in saved object import * add better assertions to verify objects are imported as expected * more discriptive variable name * add test case for imported object linked to saved search when saved search does not exist
nreese
added a commit
that referenced
this pull request
Jul 3, 2018
* disable broken functional tests in saved object import * add better assertions to verify objects are imported as expected * more discriptive variable name * add test case for imported object linked to saved search when saved search does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20398 by adding better assertions that verify that the imported saved objects where actually imported. The new assertions verify the imported saved object title exist. The saved object titles have been given names that better describe the test situations.
This PR also disables override warning functional tests in
_import_objectsthat do not actually test anything. Having the tests enabled is misleading that the functionality is working and getting tested when that is not the case. I opened #20397 to report the issue.