-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Enhance test coverage for Prebuilt Rules upgrade workflows #204677
[Security Solution] Enhance test coverage for Prebuilt Rules upgrade workflows #204677
Conversation
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7608[❌] Security Solution Rule Management - Prebuilt Rules - Cypress: 0/100 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7611[✅] Security Solution Rule Management - Prebuilt Rules - Cypress: 100/100 tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpdjere Thanks for adding rule upgrade with customization tests 🙏
I made little adjustments to rules set up by moving it to a separate function. Additionally I removed duplicated with update_workflow.cy.ts
tests.
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12582306374 |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
…workflows (elastic#204677) Addresses: elastic#202078 > NOTE: This PR depends on the test plans created in elastic#203331. If any feedback leads to changes in those test plan, these PR will be updated. ## Summary - Enhances tests on the Rule Upgrade Workflow from the Rule Updates table, as described in test plan created in: elastic#203331 ## Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611 (cherry picked from commit 529f833)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…grade workflows (#204677) (#205381) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Enhance test coverage for Prebuilt Rules upgrade workflows (#204677)](#204677) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Juan Pablo Djeredjian","email":"jpdjeredjian@gmail.com"},"sourceCommit":{"committedDate":"2025-01-02T12:18:40Z","message":"[Security Solution] Enhance test coverage for Prebuilt Rules upgrade workflows (#204677)\n\nAddresses: https://github.com/elastic/kibana/issues/202078\r\n\r\n> NOTE: This PR depends on the test plans created in #203331. If any feedback leads to changes in those test plan, these PR will be updated.\r\n\r\n## Summary\r\n\r\n- Enhances tests on the Rule Upgrade Workflow from the Rule Updates table, as described in test plan created in: https://github.com/elastic/kibana/pull/203331\r\n\r\n## Flaky test runner\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611","sha":"529f833ac83d2365df2c0ac509c55c436f0736a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","backport:version","v8.18.0"],"title":"[Security Solution] Enhance test coverage for Prebuilt Rules upgrade workflows","number":204677,"url":"https://github.com/elastic/kibana/pull/204677","mergeCommit":{"message":"[Security Solution] Enhance test coverage for Prebuilt Rules upgrade workflows (#204677)\n\nAddresses: https://github.com/elastic/kibana/issues/202078\r\n\r\n> NOTE: This PR depends on the test plans created in #203331. If any feedback leads to changes in those test plan, these PR will be updated.\r\n\r\n## Summary\r\n\r\n- Enhances tests on the Rule Upgrade Workflow from the Rule Updates table, as described in test plan created in: https://github.com/elastic/kibana/pull/203331\r\n\r\n## Flaky test runner\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611","sha":"529f833ac83d2365df2c0ac509c55c436f0736a9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204677","number":204677,"mergeCommit":{"message":"[Security Solution] Enhance test coverage for Prebuilt Rules upgrade workflows (#204677)\n\nAddresses: https://github.com/elastic/kibana/issues/202078\r\n\r\n> NOTE: This PR depends on the test plans created in #203331. If any feedback leads to changes in those test plan, these PR will be updated.\r\n\r\n## Summary\r\n\r\n- Enhances tests on the Rule Upgrade Workflow from the Rule Updates table, as described in test plan created in: https://github.com/elastic/kibana/pull/203331\r\n\r\n## Flaky test runner\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611","sha":"529f833ac83d2365df2c0ac509c55c436f0736a9"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Juan Pablo Djeredjian <jpdjeredjian@gmail.com>
…workflows (elastic#204677) Addresses: elastic#202078 > NOTE: This PR depends on the test plans created in elastic#203331. If any feedback leads to changes in those test plan, these PR will be updated. ## Summary - Enhances tests on the Rule Upgrade Workflow from the Rule Updates table, as described in test plan created in: elastic#203331 ## Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611
…workflows (elastic#204677) Addresses: elastic#202078 > NOTE: This PR depends on the test plans created in elastic#203331. If any feedback leads to changes in those test plan, these PR will be updated. ## Summary - Enhances tests on the Rule Upgrade Workflow from the Rule Updates table, as described in test plan created in: elastic#203331 ## Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611
…workflows (elastic#204677) Addresses: elastic#202078 > NOTE: This PR depends on the test plans created in elastic#203331. If any feedback leads to changes in those test plan, these PR will be updated. ## Summary - Enhances tests on the Rule Upgrade Workflow from the Rule Updates table, as described in test plan created in: elastic#203331 ## Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611
…workflows (elastic#204677) Addresses: elastic#202078 > NOTE: This PR depends on the test plans created in elastic#203331. If any feedback leads to changes in those test plan, these PR will be updated. ## Summary - Enhances tests on the Rule Upgrade Workflow from the Rule Updates table, as described in test plan created in: elastic#203331 ## Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611
Addresses: #202078
Summary
Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611