Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Enhance test coverage for Prebuilt Rules upgrade workflows #204677

Merged
merged 8 commits into from
Jan 2, 2025

Conversation

jpdjere
Copy link
Contributor

@jpdjere jpdjere commented Dec 18, 2024

Addresses: #202078

NOTE: This PR depends on the test plans created in #203331. If any feedback leads to changes in those test plan, these PR will be updated.

Summary

Flaky test runner

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611

@jpdjere jpdjere requested a review from maximpn December 18, 2024 02:17
@jpdjere jpdjere self-assigned this Dec 18, 2024
@jpdjere jpdjere added test release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area backport:version Backport to applied version labels v8.18.0 labels Dec 18, 2024
@jpdjere jpdjere marked this pull request as ready for review December 18, 2024 02:57
@jpdjere jpdjere requested a review from a team as a code owner December 18, 2024 02:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7608

[❌] Security Solution Rule Management - Prebuilt Rules - Cypress: 0/100 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7611

[✅] Security Solution Rule Management - Prebuilt Rules - Cypress: 100/100 tests passed.

see run history

@banderror banderror requested a review from pborgonovi December 23, 2024 19:09
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpdjere Thanks for adding rule upgrade with customization tests 🙏

I made little adjustments to rules set up by moving it to a separate function. Additionally I removed duplicated with update_workflow.cy.ts tests.

@maximpn maximpn enabled auto-merge (squash) January 2, 2025 10:51
@maximpn maximpn merged commit 529f833 into elastic:main Jan 2, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12582306374

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.4MB 21.4MB -11.0B

History

cc @maximpn @jpdjere

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 2, 2025
…workflows (elastic#204677)

Addresses: elastic#202078

> NOTE: This PR depends on the test plans created in elastic#203331. If any feedback leads to changes in those test plan, these PR will be updated.

## Summary

- Enhances tests on the Rule Upgrade Workflow from the Rule Updates table, as described in test plan created in: elastic#203331

## Flaky test runner

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611
(cherry picked from commit 529f833)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 2, 2025
…grade workflows (#204677) (#205381)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Enhance test coverage for Prebuilt Rules upgrade
workflows (#204677)](#204677)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Juan Pablo
Djeredjian","email":"jpdjeredjian@gmail.com"},"sourceCommit":{"committedDate":"2025-01-02T12:18:40Z","message":"[Security
Solution] Enhance test coverage for Prebuilt Rules upgrade workflows
(#204677)\n\nAddresses:
https://github.com/elastic/kibana/issues/202078\r\n\r\n> NOTE: This PR
depends on the test plans created in
#203331. If any feedback leads to
changes in those test plan, these PR will be updated.\r\n\r\n##
Summary\r\n\r\n- Enhances tests on the Rule Upgrade Workflow from the
Rule Updates table, as described in test plan created in:
https://github.com/elastic/kibana/pull/203331\r\n\r\n## Flaky test
runner\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611","sha":"529f833ac83d2365df2c0ac509c55c436f0736a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","v9.0.0","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","Feature:Prebuilt Detection
Rules","backport:version","v8.18.0"],"title":"[Security Solution]
Enhance test coverage for Prebuilt Rules upgrade
workflows","number":204677,"url":"https://github.com/elastic/kibana/pull/204677","mergeCommit":{"message":"[Security
Solution] Enhance test coverage for Prebuilt Rules upgrade workflows
(#204677)\n\nAddresses:
https://github.com/elastic/kibana/issues/202078\r\n\r\n> NOTE: This PR
depends on the test plans created in
#203331. If any feedback leads to
changes in those test plan, these PR will be updated.\r\n\r\n##
Summary\r\n\r\n- Enhances tests on the Rule Upgrade Workflow from the
Rule Updates table, as described in test plan created in:
https://github.com/elastic/kibana/pull/203331\r\n\r\n## Flaky test
runner\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611","sha":"529f833ac83d2365df2c0ac509c55c436f0736a9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204677","number":204677,"mergeCommit":{"message":"[Security
Solution] Enhance test coverage for Prebuilt Rules upgrade workflows
(#204677)\n\nAddresses:
https://github.com/elastic/kibana/issues/202078\r\n\r\n> NOTE: This PR
depends on the test plans created in
#203331. If any feedback leads to
changes in those test plan, these PR will be updated.\r\n\r\n##
Summary\r\n\r\n- Enhances tests on the Rule Upgrade Workflow from the
Rule Updates table, as described in test plan created in:
https://github.com/elastic/kibana/pull/203331\r\n\r\n## Flaky test
runner\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611","sha":"529f833ac83d2365df2c0ac509c55c436f0736a9"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Juan Pablo Djeredjian <jpdjeredjian@gmail.com>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 2, 2025
…workflows (elastic#204677)

Addresses: elastic#202078

> NOTE: This PR depends on the test plans created in elastic#203331. If any feedback leads to changes in those test plan, these PR will be updated.

## Summary

- Enhances tests on the Rule Upgrade Workflow from the Rule Updates table, as described in test plan created in: elastic#203331

## Flaky test runner

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 2, 2025
…workflows (elastic#204677)

Addresses: elastic#202078

> NOTE: This PR depends on the test plans created in elastic#203331. If any feedback leads to changes in those test plan, these PR will be updated.

## Summary

- Enhances tests on the Rule Upgrade Workflow from the Rule Updates table, as described in test plan created in: elastic#203331

## Flaky test runner

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
…workflows (elastic#204677)

Addresses: elastic#202078

> NOTE: This PR depends on the test plans created in elastic#203331. If any feedback leads to changes in those test plan, these PR will be updated.

## Summary

- Enhances tests on the Rule Upgrade Workflow from the Rule Updates table, as described in test plan created in: elastic#203331

## Flaky test runner

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
…workflows (elastic#204677)

Addresses: elastic#202078

> NOTE: This PR depends on the test plans created in elastic#203331. If any feedback leads to changes in those test plan, these PR will be updated.

## Summary

- Enhances tests on the Rule Upgrade Workflow from the Rule Updates table, as described in test plan created in: elastic#203331

## Flaky test runner

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants