Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[embeddable] remove embeddable class #205164

Merged
merged 12 commits into from
Jan 2, 2025
Merged

[embeddable] remove embeddable class #205164

merged 12 commits into from
Jan 2, 2025

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 26, 2024 •
edited by kibanamachine
Loading

Part of embeddable rebuild clean-up.

Removes legacy Embeddable class and types from embeddable plugin.

@nreese nreese changed the title [embeddable] removed embeddable class [embeddable] remove embeddable class Dec 26, 2024
@nreese
Copy link
Contributor Author

nreese commented Dec 26, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 26, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 26, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 26, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 26, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 26, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Dec 26, 2024

/ci

@nreese nreese marked this pull request as ready for review December 26, 2024 21:02
@nreese nreese requested review from a team as code owners December 26, 2024 21:02
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes labels Dec 26, 2024
@botelastic botelastic bot added Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Dec 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

mbondyra
mbondyra approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports changes for visualizations plugin LGTM 👌🏼

qn895
qn895 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@qn895 qn895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM 🎉

rudolf
rudolf reviewed Jan 2, 2025
View reviewed changes
src/plugins/visualizations/kibana.jsonc
@@ -45,7 +45,8 @@
"kibanaUtils",
"kibanaReact",
"charts",
"savedObjects"
"savedObjects",
"presentationPanel"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this bundle necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ErrorEmbeddable is moved from embeddable plugin to visualizations plugin and src/plugins/visualizations/public/legacy/embeddable/error_embeddable.tsx requires PresentationPanelError.

@nreese
Copy link
Contributor Author

nreese commented Jan 2, 2025

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

⏳ Build in-progress

  • Buildkite Build
  • Commit: e055228
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-205164-e0552286c403

History

@nreese nreese merged commit 2ee9cbf into elastic:main Jan 2, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12587170396

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 2, 2025
@nreese
[embeddable] remove embeddable class (elastic#205164)
fb57eaf 
Part of embeddable rebuild clean-up.

Removes legacy Embeddable class and types from embeddable plugin.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 2ee9cbf)
@kibanamachine kibanamachine mentioned this pull request Jan 2, 2025
Closed
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 2, 2025
@nreese @kibanamachine
@elasticmachine @cqliu1
[embeddable] remove embeddable class (elastic#205164)
a1abf1f 
Part of embeddable rebuild clean-up.

Removes legacy Embeddable class and types from embeddable plugin.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese added a commit to nreese/kibana that referenced this pull request Jan 2, 2025
@nreese
[embeddable] remove embeddable class (elastic#205164)
045b608 
Part of embeddable rebuild clean-up.

Removes legacy Embeddable class and types from embeddable plugin.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 2ee9cbf)
@nreese nreese mentioned this pull request Jan 2, 2025
Merged
@nreese
Copy link
Contributor Author

nreese commented Jan 2, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nreese added a commit that referenced this pull request Jan 2, 2025
@nreese
[8.x] [embeddable] remove embeddable class (#205164) (#205434)
4122f3b 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[embeddable] remove embeddable class
(#205164)](#205164)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2025-01-02T18:43:14Z","message":"[embeddable]
remove embeddable class (#205164)\n\nPart of embeddable rebuild
clean-up.\r\n\r\nRemoves legacy Embeddable class and types from
embeddable plugin.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"2ee9cbf377e217cac0fa07a4394d3d0d2184285c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Team:Presentation","release_note:skip","Feature:Drilldowns","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","project:embeddableRebuild","backport:version","v8.18.0"],"number":205164,"url":"https://github.com/elastic/kibana/pull/205164","mergeCommit":{"message":"[embeddable]
remove embeddable class (#205164)\n\nPart of embeddable rebuild
clean-up.\r\n\r\nRemoves legacy Embeddable class and types from
embeddable plugin.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"2ee9cbf377e217cac0fa07a4394d3d0d2184285c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205164","number":205164,"mergeCommit":{"message":"[embeddable]
remove embeddable class (#205164)\n\nPart of embeddable rebuild
clean-up.\r\n\r\nRemoves legacy Embeddable class and types from
embeddable plugin.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"2ee9cbf377e217cac0fa07a4394d3d0d2184285c"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/205427","number":205427,"state":"OPEN"}]}]
BACKPORT-->
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@nreese @kibanamachine
@elasticmachine @CAWilson94
[embeddable] remove embeddable class (elastic#205164)
4404e79 
Part of embeddable rebuild clean-up.

Removes legacy Embeddable class and types from embeddable plugin.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@nreese @kibanamachine
@elasticmachine @viduni94
[embeddable] remove embeddable class (elastic#205164)
af44d03 
Part of embeddable rebuild clean-up.

Removes legacy Embeddable class and types from embeddable plugin.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

@Dosant Dosant Dosant approved these changes

@angorayc angorayc angorayc approved these changes

@mbondyra mbondyra mbondyra approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@crespocarlos crespocarlos crespocarlos approved these changes

@nickpeihl nickpeihl nickpeihl approved these changes

@rudolf rudolf rudolf approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.