-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrectly generated code #205236
Merged
gsoldevila
merged 1 commit into
elastic:main
from
gsoldevila:fix-generate-function-definitions
Dec 30, 2024
Merged
Fix incorrectly generated code #205236
gsoldevila
merged 1 commit into
elastic:main
from
gsoldevila:fix-generate-function-definitions
Dec 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
added
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
Team:ESQL
ES|QL related features in Kibana
labels
Dec 30, 2024
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
approved these changes
Dec 30, 2024
delanni
approved these changes
Dec 30, 2024
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12545308026 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 30, 2024
## Summary Fix build issues on https://buildkite.com/elastic/kibana-es-ql-grammar-sync/builds/73 (cherry picked from commit 78a53cb)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 30, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Fix incorrectly generated code (#205236)](#205236) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2024-12-30T10:32:25Z","message":"Fix incorrectly generated code (#205236)\n\n## Summary\r\n\r\nFix build issues on\r\nhttps://buildkite.com/elastic/kibana-es-ql-grammar-sync/builds/73","sha":"78a53cb9448e72dacb7f3707e417b5580150b943","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:prev-minor","Team:ESQL"],"title":"Fix incorrectly generated code","number":205236,"url":"https://github.com/elastic/kibana/pull/205236","mergeCommit":{"message":"Fix incorrectly generated code (#205236)\n\n## Summary\r\n\r\nFix build issues on\r\nhttps://buildkite.com/elastic/kibana-es-ql-grammar-sync/builds/73","sha":"78a53cb9448e72dacb7f3707e417b5580150b943"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205236","number":205236,"mergeCommit":{"message":"Fix incorrectly generated code (#205236)\n\n## Summary\r\n\r\nFix build issues on\r\nhttps://buildkite.com/elastic/kibana-es-ql-grammar-sync/builds/73","sha":"78a53cb9448e72dacb7f3707e417b5580150b943"}}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
## Summary Fix build issues on https://buildkite.com/elastic/kibana-es-ql-grammar-sync/builds/73
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
## Summary Fix build issues on https://buildkite.com/elastic/kibana-es-ql-grammar-sync/builds/73
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 2, 2025
## Summary Fix build issues on https://buildkite.com/elastic/kibana-es-ql-grammar-sync/builds/73
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
## Summary Fix build issues on https://buildkite.com/elastic/kibana-es-ql-grammar-sync/builds/73
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
## Summary Fix build issues on https://buildkite.com/elastic/kibana-es-ql-grammar-sync/builds/73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team:ESQL
ES|QL related features in Kibana
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix build issues on https://buildkite.com/elastic/kibana-es-ql-grammar-sync/builds/73