Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upgrade assistant] Borealis updates #205345

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Jan 2, 2025

Summary

Broken out from #203664

Changes affect rendering of reindexing UI, specifically the progress indicators.

Before -

failed
failed
canceled
canceled
paused
paused
completed
completed

After

failed
Screenshot 2025-01-01 at 9 42 57 PM
canceled
Screenshot 2025-01-01 at 9 39 14 PM
paused
Screenshot 2025-01-01 at 9 38 22 PM
complete
Screenshot 2025-01-01 at 9 37 17 PM

@mattkime mattkime changed the title borealis updates [upgrade assistant] Borealis updates Jan 2, 2025
@mattkime mattkime self-assigned this Jan 2, 2025
@mattkime mattkime added Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes labels Jan 2, 2025
@mattkime mattkime mentioned this pull request Jan 2, 2025
8 tasks
@mattkime mattkime marked this pull request as ready for review January 2, 2025 04:20
@mattkime mattkime requested review from a team as code owners January 2, 2025 04:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@mattkime mattkime requested a review from Bamieh January 2, 2025 13:27
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! CCing @jovana-andjelkovic in case she wishes to add any additional comments on her return.

@mattkime mattkime enabled auto-merge (squash) January 6, 2025 03:36
@mattkime mattkime merged commit 3003d5c into elastic:main Jan 6, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12626829746

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

The CI Stats report is too large to be displayed here, check out the CI build annotation for this information.

History

cc @mattkime

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 6, 2025
## Summary
Broken out from elastic#203664

Changes affect rendering of reindexing UI, specifically the progress
indicators.

Before -

failed
<img width="312" alt="failed"
src="https://github.com/user-attachments/assets/b2444ac9-e2de-4103-9a44-b18877f5f609"
/>
canceled
<img width="303" alt="canceled"
src="https://github.com/user-attachments/assets/c1358f1e-14c1-4b1d-8870-f32d264e833f"
/>
paused
<img width="307" alt="paused"
src="https://github.com/user-attachments/assets/9731a466-fc79-41d1-94e1-da0500dbb1c4"
/>
completed
<img width="312" alt="completed"
src="https://github.com/user-attachments/assets/8d9c7037-dc33-4761-aac3-4b69d31fb72e"
/>

After

failed
<img width="307" alt="Screenshot 2025-01-01 at 9 42 57 PM"
src="https://github.com/user-attachments/assets/54ad6a52-ffa4-4cc4-b19f-8620ff4754d1"
/>
canceled
<img width="300" alt="Screenshot 2025-01-01 at 9 39 14 PM"
src="https://github.com/user-attachments/assets/2dabb927-aed7-4e82-9a4c-3973ea6f8c36"
/>
paused
<img width="299" alt="Screenshot 2025-01-01 at 9 38 22 PM"
src="https://github.com/user-attachments/assets/4f359c42-ee1f-4708-a66b-d9eda7271a15"
/>
complete
<img width="306" alt="Screenshot 2025-01-01 at 9 37 17 PM"
src="https://github.com/user-attachments/assets/c330ee41-d401-4076-afa0-8ffb95d3a775"
/>

(cherry picked from commit 3003d5c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 7, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request Jan 7, 2025
## Summary
Broken out from elastic#203664

Changes affect rendering of reindexing UI, specifically the progress
indicators.

Before - 

failed
<img width="312" alt="failed"
src="https://github.com/user-attachments/assets/b2444ac9-e2de-4103-9a44-b18877f5f609"
/>
canceled
<img width="303" alt="canceled"
src="https://github.com/user-attachments/assets/c1358f1e-14c1-4b1d-8870-f32d264e833f"
/>
paused
<img width="307" alt="paused"
src="https://github.com/user-attachments/assets/9731a466-fc79-41d1-94e1-da0500dbb1c4"
/>
completed
<img width="312" alt="completed"
src="https://github.com/user-attachments/assets/8d9c7037-dc33-4761-aac3-4b69d31fb72e"
/>

After 

failed
<img width="307" alt="Screenshot 2025-01-01 at 9 42 57 PM"
src="https://github.com/user-attachments/assets/54ad6a52-ffa4-4cc4-b19f-8620ff4754d1"
/>
canceled
<img width="300" alt="Screenshot 2025-01-01 at 9 39 14 PM"
src="https://github.com/user-attachments/assets/2dabb927-aed7-4e82-9a4c-3973ea6f8c36"
/>
paused
<img width="299" alt="Screenshot 2025-01-01 at 9 38 22 PM"
src="https://github.com/user-attachments/assets/4f359c42-ee1f-4708-a66b-d9eda7271a15"
/>
complete
<img width="306" alt="Screenshot 2025-01-01 at 9 37 17 PM"
src="https://github.com/user-attachments/assets/c330ee41-d401-4076-afa0-8ffb95d3a775"
/>
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@mattkime mattkime added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants