[Discover] Unskip functional discover request counts test and skip ES|QL part #205690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
release_note:skip
|
/ci |
kertal
commented
Jan 7, 2025
| .getEntries() | ||
| .filter((entry: any) => ['fetch', 'xmlhttprequest'].includes(entry.initiatorType)) | ||
| ); | ||
| await retry.tryWithRetries( |
There was a problem hiding this comment.
I've rewrote this part, because it's simpler for debugging. when starting this test, going to get a coffee, tryWithRetries failes earlier than try. And it makes no sense here to wait too long
💚 Build Succeeded
Metrics [docs]
cc @kertal |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7652[✅] test/functional/apps/discover/group3/config.ts: 25/25 tests passed. |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
davismcphee
approved these changes
Jan 8, 2025
kertal
added
the
backport:prev-minor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12684267014 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 9, 2025
…|QL part (elastic#205690) Unskipping the main test, and unskipping the `ES|QL` part due to flakiness (cherry picked from commit cbcb24e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 9, 2025
…kip ES|QL part (#205690) (#205993) # Backport This will backport the following commits from `main` to `8.x`: - [[Discover] Unskip functional discover request counts test and skip ES|QL part (#205690)](#205690) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthias Wilhelm","email":"matthias.wilhelm@elastic.co"},"sourceCommit":{"committedDate":"2025-01-09T05:35:40Z","message":"[Discover] Unskip functional discover request counts test and skip ES|QL part (#205690)\n\nUnskipping the main test, and unskipping the `ES|QL` part due to flakiness","sha":"cbcb24e036dd598cc4109fdb83ebdb5bcaba2d4c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"[Discover] Unskip functional discover request counts test and skip ES|QL part","number":205690,"url":"https://github.com/elastic/kibana/pull/205690","mergeCommit":{"message":"[Discover] Unskip functional discover request counts test and skip ES|QL part (#205690)\n\nUnskipping the main test, and unskipping the `ES|QL` part due to flakiness","sha":"cbcb24e036dd598cc4109fdb83ebdb5bcaba2d4c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205690","number":205690,"mergeCommit":{"message":"[Discover] Unskip functional discover request counts test and skip ES|QL part (#205690)\n\nUnskipping the main test, and unskipping the `ES|QL` part due to flakiness","sha":"cbcb24e036dd598cc4109fdb83ebdb5bcaba2d4c"}}]}] BACKPORT--> Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
Zacqary
pushed a commit
to Zacqary/kibana
that referenced
this pull request
Jan 9, 2025
…|QL part (elastic#205690) Unskipping the main test, and unskipping the `ES|QL` part due to flakiness
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…|QL part (elastic#205690) Unskipping the main test, and unskipping the `ES|QL` part due to flakiness
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…|QL part (elastic#205690) Unskipping the main test, and unskipping the `ES|QL` part due to flakiness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #205344
This PR is unskipping the main test, and unskipping the
ES|QLpart (for now, since it high likely needs to be rewritten to be unskipped, but we should not remove the code, even when skipped, it is valuable for testing)Checklist