Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vSphere Metricbeat module tutorial #20572

Merged
merged 3 commits into from
Jul 20, 2018

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Jul 9, 2018

This PR adds vSphere Metricbeat module to Add data home tutorials. This module doesn't have dashboards, so no assets are needed.

image

@exekias exekias added the Feature:Home Kibana home application label Jul 9, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@exekias
Copy link
Contributor Author

exekias commented Jul 10, 2018

It seems previous error was unrelated to this PR

//euiIconType: 'logoVSphere',
artifacts: {
dashboards: [
/*{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #20923 @ruflin took the approach of linking to the Discover page if we have no dashboard.

@tsg
Copy link
Contributor

tsg commented Jul 18, 2018

Requires a rebase now, and see minor comment. Otherwise, LGTM.

exekias added 2 commits July 20, 2018 12:02
This module doesn't have dashboards, so no assets are needed.
@exekias exekias force-pushed the metricbeat_vsphere_tutorial branch from 0ead5ff to fa233ee Compare July 20, 2018 10:17
@exekias
Copy link
Contributor Author

exekias commented Jul 20, 2018

pointing to Discover page is a great idea, I pushed a new commit to include that

path: '/app/kibana#/discover'
},
dashboards: [
/*{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed now.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@ruflin
Copy link
Contributor

ruflin commented Jul 20, 2018

@exekias The build failure is not related. You can merge. Please also backport. You can use node scripts/backport.js for it.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@exekias exekias merged commit d787ffb into elastic:master Jul 20, 2018
exekias added a commit to exekias/kibana that referenced this pull request Jul 20, 2018
* Add vSphere Metricbeat module tutorial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Home Kibana home application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants