Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Eui visual refresh - make palettes theme aware #205873

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Jan 8, 2025

Summary

This PR resolves #201882 by making sure that EUI palette functions are called during component re-renders in Security Solution.

Testing

Please verify if visualizations are displayed properly.

Running Kibana with the Borealis theme
In order to run Kibana with Borealis, you'll need to do the following:

Set the following in kibana.dev.yml: uiSettings.experimental.themeSwitcherEnabled: true

Run Kibana with the following environment variable set:
KBN_OPTIMIZER_THEMES="borealislight,borealisdark,v8light,v8dark" yarn start

This will expose a toggle under Stack Management > Advanced Settings > Theme version, which you can use to toggle between Amsterdam and Borealis.

@lgestc lgestc changed the title --wip-- [skip ci] [Security Solution] Eui visual refresh - make palettes theme aware Jan 8, 2025
@elastic elastic deleted a comment from elasticmachine Jan 8, 2025
@lgestc lgestc marked this pull request as ready for review January 8, 2025 19:41
@lgestc lgestc requested a review from a team as a code owner January 8, 2025 19:41
@lgestc lgestc added backport:skip This commit does not require backporting Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting:Explore labels Jan 8, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@lgestc lgestc requested a review from machadoum January 8, 2025 19:42
@lgestc lgestc added the release_note:skip Skip the PR/issue when compiling release notes label Jan 8, 2025
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Lucas, thanks so much for updating the configs for map and visualizations:
I think we can keep the changes for map, as for visualizations should have been updated in the PRs below:
#204631 (comment)
#206254

@lgestc lgestc force-pushed the ensure_pallete_reload_on_rerender branch from 3fce630 to 9825390 Compare January 13, 2025 14:06
@lgestc
Copy link
Contributor Author

lgestc commented Jan 13, 2025

Hey Lucas, thanks so much for updating the configs for map and visualizations: I think we can keep the changes for map, as for visualizations should have been updated in the PRs below: #204631 (comment) #206254

Done, this PR is just about the map config now:) @angorayc

@lgestc lgestc requested a review from angorayc January 14, 2025 17:14
@elastic elastic deleted a comment from elasticmachine Jan 27, 2025
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code changes LGTM from EUI side.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.6MB 21.6MB +194.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting:Investigations Security Solution Investigations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution][EUI visual refresh] make sure color palettes are theme aware
5 participants