Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rules migration] Implement workflow tour - Rule Translation (#11384) #207425

Merged
merged 8 commits into from
Jan 27, 2025
Merged

[Rules migration] Implement workflow tour - Rule Translation (#11384) #207425

merged 8 commits into from
Jan 27, 2025
+333 −13

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Jan 21, 2025 •
edited by kibanamachine
Loading

Summary

Internal link to the feature details

This PR adds the SIEM Migration tour guide on the Translated Rules page. Figma link

The tour will be on when there are at least one translated rule in the opened migration (rules table is not empty).

Screen.Recording.2025-01-21.at.19.04.07.mov

Delete securitySolution.siemMigrations.ruleTranslationGuide.v8.18 in the local storage to reset the tour.

Note

This feature needs siemMigrationsEnabled experimental flag enabled to work.

@e40pud e40pud added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Jan 21, 2025
@e40pud e40pud requested a review from semd January 21, 2025 18:06
@e40pud e40pud self-assigned this Jan 21, 2025
@e40pud e40pud requested review from a team as code owners January 21, 2025 18:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@e40pud e40pud changed the title Security/siem migrations/11384 translated rules guide [Rules migration] Implement workflow tour - Rule Translation (#11384) Jan 21, 2025
KDKHD
KDKHD reviewed Jan 23, 2025
View reviewed changes
.../security_solution/public/siem_migrations/rules/components/tours/translation_guide/index.tsx Outdated
Comment on lines 38 to 43
{
step: 1,
title: i18n.MIGRATION_RULES_SELECTOR_TOUR_STEP_TITLE,
content: i18n.MIGRATION_RULES_SELECTOR_TOUR_STEP_CONTENT,
anchorPosition: 'downCenter',
},
Copy link
Member

@KDKHD KDKHD Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit/question: How come you don't store the anchors in here too

Suggested change
{
step: 1,
title: i18n.MIGRATION_RULES_SELECTOR_TOUR_STEP_TITLE,
content: i18n.MIGRATION_RULES_SELECTOR_TOUR_STEP_CONTENT,
anchorPosition: 'downCenter',
},
{
step: 1,
title: i18n.MIGRATION_RULES_SELECTOR_TOUR_STEP_TITLE,
content: i18n.MIGRATION_RULES_SELECTOR_TOUR_STEP_CONTENT,
anchorPosition: 'downCenter',
anchor: `#${SIEM_MIGRATIONS_SELECT_MIGRATION_BUTTON_ID}`
},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Addressed in 37d5846

@e40pud
Copy link
Contributor Author

e40pud commented Jan 25, 2025

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6590 6593 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.3MB 21.3MB +5.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 88.1KB 88.2KB +88.0B

History

cc @e40pud

semd
semd approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@e40pud e40pud merged commit ef58b46 into elastic:main Jan 27, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12986300607

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 27, 2025
@e40pud
[Rules migration] Implement workflow tour - Rule Translation (elastic…
b74ed4f 
…#11384) (elastic#207425)

## Summary

[Internal link](elastic/security-team#10820)
to the feature details

This PR adds the SIEM Migration tour guide on the Translated Rules page.
[Figma
link](https://www.figma.com/design/BD9GZZz6y8pfSbubAt5H2W/%5B8.18%5D-GenAI-Powered-SIEM-Migration%3A-Rule-translation?node-id=2652-255044&t=hpdjyIzzG4XcwLSU-4)

The tour will be on when there are at least one translated rule in the
opened migration (rules table is not empty).

https://github.com/user-attachments/assets/8b29d8d5-43ce-4f4e-9821-595899ba3d25

Delete `securitySolution.siemMigrations.ruleTranslationGuide.v8.18` in
the local storage to reset the tour.

> [!NOTE]
> This feature needs `siemMigrationsEnabled` experimental flag enabled
to work.

(cherry picked from commit ef58b46)
@kibanamachine kibanamachine mentioned this pull request Jan 27, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 27, 2025
@kibanamachine @e40pud
[8.x] [Rules migration] Implement workflow tour - Rule Translation (#…
3f4dc03 
…11384) (#207425) (#208327)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Rules migration] Implement workflow tour - Rule Translation (#11384)
(#207425)](#207425)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2025-01-27T09:52:53Z","message":"[Rules
migration] Implement workflow tour - Rule Translation (#11384)
(#207425)\n\n## Summary\r\n\r\n[Internal
link](https://github.com/elastic/security-team/issues/10820)\r\nto the
feature details\r\n\r\nThis PR adds the SIEM Migration tour guide on the
Translated Rules
page.\r\n[Figma\r\nlink](https://www.figma.com/design/BD9GZZz6y8pfSbubAt5H2W/%5B8.18%5D-GenAI-Powered-SIEM-Migration%3A-Rule-translation?node-id=2652-255044&t=hpdjyIzzG4XcwLSU-4)\r\n\r\nThe
tour will be on when there are at least one translated rule in
the\r\nopened migration (rules table is not
empty).\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8b29d8d5-43ce-4f4e-9821-595899ba3d25\r\n\r\nDelete
`securitySolution.siemMigrations.ruleTranslationGuide.v8.18` in\r\nthe
local storage to reset the tour.\r\n\r\n> [!NOTE] \r\n> This feature
needs `siemMigrationsEnabled` experimental flag enabled\r\nto
work.","sha":"ef58b46c121e3d2244c4713f4681c4c6dbce91bd","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting","Team: SecuritySolution","backport:prev-minor"],"title":"[Rules
migration] Implement workflow tour - Rule Translation
(#11384)","number":207425,"url":"https://github.com/elastic/kibana/pull/207425","mergeCommit":{"message":"[Rules
migration] Implement workflow tour - Rule Translation (#11384)
(#207425)\n\n## Summary\r\n\r\n[Internal
link](https://github.com/elastic/security-team/issues/10820)\r\nto the
feature details\r\n\r\nThis PR adds the SIEM Migration tour guide on the
Translated Rules
page.\r\n[Figma\r\nlink](https://www.figma.com/design/BD9GZZz6y8pfSbubAt5H2W/%5B8.18%5D-GenAI-Powered-SIEM-Migration%3A-Rule-translation?node-id=2652-255044&t=hpdjyIzzG4XcwLSU-4)\r\n\r\nThe
tour will be on when there are at least one translated rule in
the\r\nopened migration (rules table is not
empty).\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8b29d8d5-43ce-4f4e-9821-595899ba3d25\r\n\r\nDelete
`securitySolution.siemMigrations.ruleTranslationGuide.v8.18` in\r\nthe
local storage to reset the tour.\r\n\r\n> [!NOTE] \r\n> This feature
needs `siemMigrationsEnabled` experimental flag enabled\r\nto
work.","sha":"ef58b46c121e3d2244c4713f4681c4c6dbce91bd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207425","number":207425,"mergeCommit":{"message":"[Rules
migration] Implement workflow tour - Rule Translation (#11384)
(#207425)\n\n## Summary\r\n\r\n[Internal
link](https://github.com/elastic/security-team/issues/10820)\r\nto the
feature details\r\n\r\nThis PR adds the SIEM Migration tour guide on the
Translated Rules
page.\r\n[Figma\r\nlink](https://www.figma.com/design/BD9GZZz6y8pfSbubAt5H2W/%5B8.18%5D-GenAI-Powered-SIEM-Migration%3A-Rule-translation?node-id=2652-255044&t=hpdjyIzzG4XcwLSU-4)\r\n\r\nThe
tour will be on when there are at least one translated rule in
the\r\nopened migration (rules table is not
empty).\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8b29d8d5-43ce-4f4e-9821-595899ba3d25\r\n\r\nDelete
`securitySolution.siemMigrations.ruleTranslationGuide.v8.18` in\r\nthe
local storage to reset the tour.\r\n\r\n> [!NOTE] \r\n> This feature
needs `siemMigrationsEnabled` experimental flag enabled\r\nto
work.","sha":"ef58b46c121e3d2244c4713f4681c4c6dbce91bd"}}]}] BACKPORT-->

Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Jan 27, 2025
@e40pud @JoseLuisGJ
[Rules migration] Implement workflow tour - Rule Translation (elastic…
f4ed2fc 
…#11384) (elastic#207425)

## Summary

[Internal link](elastic/security-team#10820)
to the feature details

This PR adds the SIEM Migration tour guide on the Translated Rules page.
[Figma
link](https://www.figma.com/design/BD9GZZz6y8pfSbubAt5H2W/%5B8.18%5D-GenAI-Powered-SIEM-Migration%3A-Rule-translation?node-id=2652-255044&t=hpdjyIzzG4XcwLSU-4)

The tour will be on when there are at least one translated rule in the
opened migration (rules table is not empty).


https://github.com/user-attachments/assets/8b29d8d5-43ce-4f4e-9821-595899ba3d25

Delete `securitySolution.siemMigrations.ruleTranslationGuide.v8.18` in
the local storage to reset the tour.

> [!NOTE]  
> This feature needs `siemMigrationsEnabled` experimental flag enabled
to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd approved these changes

@KDKHD KDKHD KDKHD approved these changes

Assignees

@e40pud e40pud

Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@e40pud @elasticmachine @kibanamachine @semd @KDKHD