[Reporting] Blacklist Transfer-Encoding HTTP header for PDF report generation.
#20755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
bug
💚 Build Succeeded |
azasypkin
commented
Jul 13, 2018
| }); | ||
|
|
||
| afterEach(() => generatePdfObservableFactory.mockReset()); |
There was a problem hiding this comment.
note: we need this to make sure that every test tests what it should. E.g. omits blacklisted headers should fail if we add some header to blacklistedHeaders that's not blacklisted in real code, but it passed before this change since generatePdfObservable mock call history was shared between tests.
epixa
approved these changes
Jul 13, 2018
stacey-gammon
approved these changes
Jul 13, 2018
|
6.x/6.4: 31c633e |
yankouskia
pushed a commit
to yankouskia/kibana
that referenced
this pull request
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #18951 base path proxy started to use
Hapi v17andh2o2 v8.1.2, that may addTransfer-Encoding: chunkedHTTP header to requests that are being proxied. That sounds like a reasonable thing to do and not sure why previous versions didn't do that.Transfer-Encodingis hop-by-hop header that is meaningful only for a single transport-level connection, and shouldn't be stored by caches or forwarded by proxies. This affected reporting since PDF generation forces underlying browser to re-transmit some of the headers from the original request that created PDF generation job with every request used during screenshotting, includingTransfer-Encoding: chunked. That doesn't make any sense and gets worse when underlying browser addsContent-Lengthheader and hence violates HTTP spec, makes Node to reject such requests and fail PDF generation job as a result.It feels like it can happen in a wild even without the change introduced by the new platform, so I'm proposing to just blacklist
Transfer-EncodingHTTP header.To test, please try to generate PDF reports when Kibana is run in dev mode:
Fixes #20724