Bump eui #20774

stacey-gammon · 2018-07-13T16:01:02Z

No description provided.

elasticmachine · 2018-07-13T17:07:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

w33ble · 2018-07-13T18:31:14Z

@stacey-gammon what version(s) are you planning to target here?

stacey-gammon · 2018-07-13T19:54:31Z

@w33ble, 6.x and 7.0. I'm not sure of the protocol, but I have some typings that are in 2.0 that I'd like to work against. I also added a comment on your PR.

cchaos · 2018-07-13T20:55:52Z

These pages (the expanded ones) will need to be updated to fix the breaking changes from EuiPage.

Mainly adding `EuiPageBody`’s where there were none

…st snapshots

elasticmachine · 2018-07-14T13:40:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

Fixed breaking `EuiPage` changes

elasticmachine · 2018-07-16T13:48:58Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…st snapshots

elasticmachine · 2018-07-16T17:08:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2018-07-16T18:14:03Z

homepage looks good:

cchaos · 2018-07-16T19:06:01Z

@stacey-gammon I'm confused, where did my fixes PR go? The changes are not in here and the homepage layout is broke again.

stacey-gammon · 2018-07-16T19:07:45Z

that's really weird @cchaos! I have no idea. Hmmm, let me see if I can remerge the changes.

elasticmachine · 2018-07-17T01:35:45Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-07-17T14:21:15Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2018-07-17T14:45:21Z

well I added your changes and updated the xpack snapshot tests @cchaos but i think now fialing on yet more flaky tests 😭

UI Functional Tests.test/functional/apps/management/_kibana_settings·js.management kibana settings "after all" hook

lets find out.

jenkins, test this.

cchaos · 2018-07-17T15:01:43Z

Yeah, something about this missing selector [data-test-subj="advancedSetting-editField-dateFormat:tz"]...?

elasticmachine · 2018-07-17T16:06:56Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

stacey-gammon · 2018-07-17T16:44:38Z

Filed the flaky test issue here: #20893

ready for review

stacey-gammon · 2018-07-17T18:33:56Z

Ready for final review. Am out tomorrow - Friday so if I don't get it in today, this will either have to wait till next week or someone else will have to take over.

cchaos

I believe all the EuiPage instances have been found and updated with EuiPageBody. LGTM

stacey-gammon · 2018-07-17T19:34:15Z

@cchaos - is this supposed to happen on dashboard listing page (note vertically centered is new i think):

Tried to manually review all the other changed snapshots and they look good as far as i can tell.

cchaos · 2018-07-17T19:42:05Z

@stacey-gammon Yes, that's on purpose via this line introduced during the EUI-ification of that page.

snide · 2018-07-17T20:26:03Z

Ha. I'll clean that up post this PR @stacey-gammon. That line @cchaos is pointing to likely wasn't working (she fixed it!) when I implemented it. I agree it looks goofy :)

Thanks for getting this stuff in.

nreese · 2018-07-17T20:38:45Z

src/core_plugins/kibana/public/home/components/tutorial/tutorial.js

-        <EuiLink href="#/home">Home</EuiLink> / <EuiLink href="#/home/tutorial_directory">Add Data</EuiLink>
-        <EuiSpacer size="s" />
-        {content}
+          <div>


Why is the EUILink now wrapped in a div?

@cchaos can you answer this? It's part of the code you made that I merged into this PR.

Because EuiPageBody is a flex-box of column direction and so each child would be on it's on line even if they're inline style elements like link tags. Wrapping these breadcrumbs in a div, keeps them as one individual flex-item.

sorry for the double-post, gh is being stupid

nreese

lgtm other than a question about adding a div element
code review, looked through home page, add data, dashboard, and management screens to view new EUI look

cchaos · 2018-07-17T22:23:27Z

@stacey-gammon Looks like this should be gtg!

stacey-gammon · 2018-07-17T22:43:51Z

Great! I'm on my phone right now, ended with for the day. Will merge once I get to a computer or feel free to hit the merge button sooner if it's blocking anyone. Not logged in on my phone so can't do it this second.

…

On Tue, Jul 17, 2018, 6:23 PM Caroline Horn ***@***.***> wrote: @stacey-gammon <https://github.com/Stacey-Gammon> Looks like this should be gtg! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20774 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APy9kx91FOIJvR_NDjM7Js3_JVj1pZcMks5uHmP1gaJpZM4VPInZ> .

* bump eui * Fixed breaking `EuiPage` changes Mainly adding `EuiPageBody`’s where there were none * bump to 3.0, remove duplicate declaration of EuiFlyoutBody, update jest snapshots * bump eui * bump to 3.0, remove duplicate declaration of EuiFlyoutBody, update jest snapshots * Update jest snapshots in xpack

snide · 2018-07-18T14:33:05Z

For the future, reminder to everyone that we need to set dependencies is BOTH package.json and xpack/package.json.

No worries, I missed it to. Have a follow up PR to fix. #20930

nreese · 2018-07-18T14:41:05Z

Lets just take the dependency out of x-pack. That way there is only one version

bump eui

68d199a

w33ble added chore v7.0.0 v6.4.0 labels Jul 13, 2018

w33ble mentioned this pull request Jul 13, 2018

Chore: bump eui to 1.2.1 #20790

Closed

cchaos and others added 2 commits July 13, 2018 18:09

Fixed breaking EuiPage changes

85a31a0

Mainly adding `EuiPageBody`’s where there were none

bump to 3.0, remove duplicate declaration of EuiFlyoutBody, update je…

759e9d0

…st snapshots

Merge pull request #7 from cchaos/sgammon_2018-07-13-bump-eui

3f06ba5

Fixed breaking `EuiPage` changes

stacey-gammon added 2 commits July 16, 2018 11:41

bump eui

67a8974

bump to 3.0, remove duplicate declaration of EuiFlyoutBody, update je…

bc453c0

…st snapshots

stacey-gammon force-pushed the 2018-07-13-bump-eui branch from 3f06ba5 to bc453c0 Compare July 16, 2018 15:45

stacey-gammon requested a review from cchaos July 16, 2018 18:14

stacey-gammon added the :Sharing label Jul 16, 2018

stacey-gammon requested a review from nreese July 16, 2018 18:23

Merge commit '3f06ba5' into 2018-07-13-bump-eui

03209e5

Update jest snapshots in xpack

06501dd

stacey-gammon mentioned this pull request Jul 17, 2018

Flaky management test: functional/apps/management/_kibana_settings·js.management kibana settings "after all" hook #20893

Closed

cchaos approved these changes Jul 17, 2018

View reviewed changes

nreese reviewed Jul 17, 2018

View reviewed changes

nreese approved these changes Jul 17, 2018

View reviewed changes

stacey-gammon merged commit e90f652 into elastic:master Jul 17, 2018

stacey-gammon mentioned this pull request Jul 17, 2018

[6.x] Bump eui (#20774) #20909

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump eui #20774

Bump eui #20774

stacey-gammon commented Jul 13, 2018

elasticmachine commented Jul 13, 2018

w33ble commented Jul 13, 2018

stacey-gammon commented Jul 13, 2018

cchaos commented Jul 13, 2018

elasticmachine commented Jul 14, 2018

elasticmachine commented Jul 16, 2018

elasticmachine commented Jul 16, 2018

stacey-gammon commented Jul 16, 2018

cchaos commented Jul 16, 2018

stacey-gammon commented Jul 16, 2018

elasticmachine commented Jul 17, 2018

elasticmachine commented Jul 17, 2018

stacey-gammon commented Jul 17, 2018

cchaos commented Jul 17, 2018

elasticmachine commented Jul 17, 2018

stacey-gammon commented Jul 17, 2018

stacey-gammon commented Jul 17, 2018

cchaos left a comment

stacey-gammon commented Jul 17, 2018 •

edited

Loading

cchaos commented Jul 17, 2018

snide commented Jul 17, 2018

nreese Jul 17, 2018 •

edited

Loading

stacey-gammon Jul 17, 2018

cchaos Jul 17, 2018

cchaos Jul 17, 2018

nreese left a comment

cchaos commented Jul 17, 2018

stacey-gammon commented Jul 17, 2018 via email

snide commented Jul 18, 2018

nreese commented Jul 18, 2018

Bump eui #20774

Bump eui #20774

Conversation

stacey-gammon commented Jul 13, 2018

elasticmachine commented Jul 13, 2018

💔 Build Failed

w33ble commented Jul 13, 2018

stacey-gammon commented Jul 13, 2018

cchaos commented Jul 13, 2018

elasticmachine commented Jul 14, 2018

💔 Build Failed

elasticmachine commented Jul 16, 2018

💔 Build Failed

elasticmachine commented Jul 16, 2018

💚 Build Succeeded

stacey-gammon commented Jul 16, 2018

cchaos commented Jul 16, 2018

stacey-gammon commented Jul 16, 2018

elasticmachine commented Jul 17, 2018

💔 Build Failed

elasticmachine commented Jul 17, 2018

💔 Build Failed

stacey-gammon commented Jul 17, 2018

cchaos commented Jul 17, 2018

elasticmachine commented Jul 17, 2018

💚 Build Succeeded

stacey-gammon commented Jul 17, 2018

stacey-gammon commented Jul 17, 2018

cchaos left a comment

Choose a reason for hiding this comment

stacey-gammon commented Jul 17, 2018 • edited Loading

cchaos commented Jul 17, 2018

snide commented Jul 17, 2018

nreese Jul 17, 2018 • edited Loading

Choose a reason for hiding this comment

stacey-gammon Jul 17, 2018

Choose a reason for hiding this comment

cchaos Jul 17, 2018

Choose a reason for hiding this comment

cchaos Jul 17, 2018

Choose a reason for hiding this comment

nreese left a comment

Choose a reason for hiding this comment

cchaos commented Jul 17, 2018

stacey-gammon commented Jul 17, 2018 via email

snide commented Jul 18, 2018

nreese commented Jul 18, 2018

stacey-gammon commented Jul 17, 2018 •

edited

Loading

nreese Jul 17, 2018 •

edited

Loading