-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra UI] Add configuration options and source graphql api #20789
Merged
weltenwort
merged 6 commits into
elastic:feature-infra-ui
from
weltenwort:infra-ui-enhancement-configuration-api
Jul 19, 2018
Merged
[Infra UI] Add configuration options and source graphql api #20789
weltenwort
merged 6 commits into
elastic:feature-infra-ui
from
weltenwort:infra-ui-enhancement-configuration-api
Jul 19, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
WIP
Work in progress
:Ingest UI
Feature:Metrics UI
Metrics UI feature
labels
Jul 13, 2018
💚 Build Succeeded |
💔 Build Failed |
weltenwort
force-pushed
the
infra-ui-enhancement-configuration-api
branch
from
July 14, 2018 22:39
fc1f648
to
eefb0d7
Compare
💚 Build Succeeded |
weltenwort
changed the title
[WIP] [Infra UI] Add configuration options and graphql api
[WIP] [Infra UI] Add configuration options and source graphql api
Jul 16, 2018
This distributes most of the types from `infra_types.ts` into the `adapter_types.ts` of the respective adapters. It also moves nodes-specific stuff into the nodes adapter directory in preparation for the configuration domain.
weltenwort
force-pushed
the
infra-ui-enhancement-configuration-api
branch
from
July 17, 2018 10:05
eefb0d7
to
31d4628
Compare
💚 Build Succeeded |
weltenwort
changed the title
[WIP] [Infra UI] Add configuration options and source graphql api
[Infra UI] Add configuration options and source graphql api
Jul 18, 2018
💚 Build Succeeded |
weltenwort
force-pushed
the
infra-ui-enhancement-configuration-api
branch
from
July 18, 2018 17:50
5a69cb8
to
46a8c43
Compare
💔 Build Failed |
simianhacker
approved these changes
Jul 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... I tested it with GraphiQL
💚 Build Succeeded |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Configuration
This PR adds new Kibana configuration options under the key
xpack.infra
. Any settings given in Kibana's configuration file will be overlaid on top of the following defaults (as discussed in #20428):New GraphQL Queries
Based on the configuration introduced above, the following endpoints have been added:
source(id)
Example
allSources
Example
Other Notes
This also distributes most of the types from
infra_types.ts
into theadapter_types.ts
of the respective adapters. It also moves functions and types specific to the "nodes" domain into the nodes adapter directory to increase local cohesion.The source defaults are applied inside of the source lib instead of the configuration schema to maintain separation of concerns and because the configuration schema is Kibana-specific.
Follow-up Tasks
map()
query type inside ofsource()
source().indices
field to diagnose matching indicessource().capabilities
field to communicate detected data characteristics