[ci] Don't start APM/Profiling cypress if pre-checks don't pass #208569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pre-check passed
delanni
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Jan 28, 2025
|
Starting backport for target branches: 7.17, 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/13015939470 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 28, 2025
…tic#208569) ## Summary https://buildkite.com/elastic/kibana-on-merge/builds/60136 shows how even though some preliminary checks failed, some cypress tests started after the build step was successful. It's probably because they had explicit dependencies, but only on a subset of the pre-checks. (cherry picked from commit 90d768b)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 28, 2025
…x27;t pass (#208569) (#208585) # Backport This will backport the following commits from `main` to `8.x`: - [[ci] Don't start APM/Profiling cypress if pre-checks don't pass (#208569)](#208569) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2025-01-28T17:19:52Z","message":"[ci] Don't start APM/Profiling cypress if pre-checks don't pass (#208569)\n\n## Summary\nhttps://buildkite.com/elastic/kibana-on-merge/builds/60136 shows how\neven though some preliminary checks failed, some cypress tests started\nafter the build step was successful. It's probably because they had\nexplicit dependencies, but only on a subset of the pre-checks.","sha":"90d768be9b35ac26a3b938edac5c1af47cab980a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:all-open"],"title":"[ci] Don't start APM/Profiling cypress if pre-checks don't pass","number":208569,"url":"https://github.com/elastic/kibana/pull/208569","mergeCommit":{"message":"[ci] Don't start APM/Profiling cypress if pre-checks don't pass (#208569)\n\n## Summary\nhttps://buildkite.com/elastic/kibana-on-merge/builds/60136 shows how\neven though some preliminary checks failed, some cypress tests started\nafter the build step was successful. It's probably because they had\nexplicit dependencies, but only on a subset of the pre-checks.","sha":"90d768be9b35ac26a3b938edac5c1af47cab980a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208569","number":208569,"mergeCommit":{"message":"[ci] Don't start APM/Profiling cypress if pre-checks don't pass (#208569)\n\n## Summary\nhttps://buildkite.com/elastic/kibana-on-merge/builds/60136 shows how\neven though some preliminary checks failed, some cypress tests started\nafter the build step was successful. It's probably because they had\nexplicit dependencies, but only on a subset of the pre-checks.","sha":"90d768be9b35ac26a3b938edac5c1af47cab980a"}}]}] BACKPORT--> Co-authored-by: Alex Szabo <alex.szabo@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://buildkite.com/elastic/kibana-on-merge/builds/60136 shows how even though some preliminary checks failed, some cypress tests started after the build step was successful. It's probably because they had explicit dependencies, but only on a subset of the pre-checks.