Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Add "All logs" data view to classic nav #209042

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davismcphee
Copy link
Contributor

Summary

This PR adds the default "All logs" data view introduced in #205991 to the classic nav in addition to Observability nav.

Resolves #209013.

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@davismcphee davismcphee added release_note:enhancement v9.0.0 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:obs-ux-logs Observability Logs User Experience Team backport:version Backport to applied version labels v8.18.0 v9.1.0 v8.19.0 labels Jan 31, 2025
@davismcphee davismcphee self-assigned this Jan 31, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 31, 2025

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!


import { i18n } from '@kbn/i18n';

export const ALL_LOGS_DATA_VIEW_ID = 'discover-observability-root-profile-all-logs';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this hasn't released yet, I wonder if we should take the opportunity to change this ID to something more generic like discover-observability-solution-all-logs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered sharing this between the o11y root profile and this one, but figured they could diverge so I just copied it over.

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 31, 2025

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #68 / Advanced Settings security feature controls no advanced_settings privileges "after all" hook: afterTestSuite.trigger for "does not allow navigation to advanced settings; shows "not found" error"
  • [job] [logs] FTR Configs #47 / discover feature controls spaces space with index pattern management disabled shows empty prompt when no data views exist
  • [job] [logs] FTR Configs #47 / discover feature controls spaces space with index pattern management disabled shows empty prompt when no data views exist
  • [job] [logs] FTR Configs #21 / discover/esql discover esql view switch modal should show available data views after switching to classic mode
  • [job] [logs] FTR Configs #21 / discover/esql discover esql view switch modal should show available data views after switching to classic mode
  • [job] [logs] FTR Configs #26 / discover/group5 discover no data adds a new data view when no data views
  • [job] [logs] FTR Configs #26 / discover/group5 discover no data adds a new data view when no data views

History

cc @davismcphee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:enhancement Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:obs-ux-logs Observability Logs User Experience Team v8.18.0 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discover] Allow accessing Observability "All logs" default data view in classic nav
2 participants