-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Add "All logs" data view to classic nav #209042
base: main
Are you sure you want to change the base?
[Discover] Add "All logs" data view to classic nav #209042
Conversation
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
|
||
import { i18n } from '@kbn/i18n'; | ||
|
||
export const ALL_LOGS_DATA_VIEW_ID = 'discover-observability-root-profile-all-logs'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this hasn't released yet, I wonder if we should take the opportunity to change this ID to something more generic like discover-observability-solution-all-logs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered sharing this between the o11y root profile and this one, but figured they could diverge so I just copied it over.
⏳ Build in-progress, with failures
Failed CI Steps
Test Failures
Historycc @davismcphee |
Summary
This PR adds the default "All logs" data view introduced in #205991 to the classic nav in addition to Observability nav.
Resolves #209013.
Checklist
release_note:breaking
label should be applied in these situations.release_note:*
label is applied per the guidelines