Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Explorer] Add redirect for old logs settings page #209452

Conversation

achyutjhunjhunwala
Copy link
Contributor

Summary

Closes - #209270

Added a redirect from old deprecated Logs Settings Page to Kibana Advance Settings page

@achyutjhunjhunwala achyutjhunjhunwala added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team labels Feb 4, 2025
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Feb 4, 2025
@achyutjhunjhunwala achyutjhunjhunwala requested a review from a team as a code owner February 4, 2025 06:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@achyutjhunjhunwala achyutjhunjhunwala added the backport:skip This commit does not require backporting label Feb 4, 2025
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner February 4, 2025 07:13
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a non-blocking nit 👌

Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achyutjhunjhunwala achyutjhunjhunwala enabled auto-merge (squash) February 4, 2025 09:09
@achyutjhunjhunwala achyutjhunjhunwala merged commit 7e6fb93 into elastic:main Feb 4, 2025
9 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #20 / Screenshots - serverless security UI response ops docs security cases list view cases list screenshot

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1302 1303 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.2MB 1.2MB +257.0B

History

cc @achyutjhunjhunwala

@achyutjhunjhunwala achyutjhunjhunwala deleted the add-redirect-for-old-logs-settings-page branch February 5, 2025 04:41
drewdaemon pushed a commit to drewdaemon/kibana that referenced this pull request Feb 6, 2025
## Summary

Closes - elastic#209270

Added a redirect from old deprecated Logs Settings Page to Kibana
Advance Settings page

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants