-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed linechart zero-injection, closes #2102 #2118
Conversation
@@ -19,20 +19,25 @@ define(function (require) { | |||
var flattenedData = flattenDataArray(obj); | |||
var uniqueXValues = {}; | |||
|
|||
var isDate = (obj.ordered && obj.ordered.date); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move this var statement to line 20, right after
var flattenedData = flattenDataArray(obj);
The reason issue #2102 occurred was due to the fix I put in for issue #1903. The issue in #1903 was that the ordering of vertical bars was incorrect when using a terms aggregation with x axis values that are numbers. For example, when looking at the By default bars should be ordered descending with the x axis values with the highest y axis values appearing first. Since this is the default that elasticsearch returns, we only needed to order the x values by their indexed position in our zero injection code. However, when x axis values are dates and a |
@stormpython I fixed order of vars and updated comments with more details. |
Is there a test for this? |
fixed linechart zero-injection, closes #2102
@spenceralger this closes #2102
shelby and I worked on the update, we needed to distinguish between numbers and dates to fix sorting of values.
related to issue #1903 and pr #1968