Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip scale tick tests because of flaky #21641

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Aug 3, 2018

Skip flaky tests identified by #21642 on scale checks

Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you make sure there's an issue open for these and linked to from here?

@markov00
Copy link
Member Author

markov00 commented Aug 3, 2018

@jbudz I've just created the issue and updated the description.
I will wait for CI tests to pass and than merge

@kobelb kobelb self-requested a review August 3, 2018 13:00
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes merged commit 5f52df0 into elastic:master Aug 3, 2018
markov00 added a commit to markov00/kibana that referenced this pull request Aug 3, 2018
markov00 added a commit to markov00/kibana that referenced this pull request Aug 3, 2018
markov00 added a commit that referenced this pull request Aug 3, 2018
…k tests because of possible flakyness (#21641) (#21647)

* Fix hidden ticks when using log scale (#21507)

* Add support for vertical axis

The vertical axis scale has an inverted range (max, min) and we need to compute the absolute scale width instead.

* Add functional test for Y axis scale type  switching

* Remove unnecessary waitUntilLoadingHasFinished

* Skip scale tick tests because of possible flakyness (#21641)
markov00 added a commit that referenced this pull request Aug 3, 2018
…k tests because of possible flakyness (#21641) (#21648)

* Fix hidden ticks when using log scale (#21507)

* Add support for vertical axis

The vertical axis scale has an inverted range (max, min) and we need to compute the absolute scale width instead.

* Add functional test for Y axis scale type  switching

* Remove unnecessary waitUntilLoadingHasFinished

* Skip scale tick tests because of possible flakyness (#21641)
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae liza-mae added failed-test A test failure on a tracked branch, potentially flaky-test and removed flaky-failing-test labels Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants