-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip scale tick tests because of flaky #21641
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
approved these changes
Aug 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you make sure there's an issue open for these and linked to from here?
@jbudz I've just created the issue and updated the description. |
kobelb
approved these changes
Aug 3, 2018
💚 Build Succeeded |
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Aug 3, 2018
markov00
added a commit
to markov00/kibana
that referenced
this pull request
Aug 3, 2018
markov00
added a commit
that referenced
this pull request
Aug 3, 2018
…k tests because of possible flakyness (#21641) (#21647) * Fix hidden ticks when using log scale (#21507) * Add support for vertical axis The vertical axis scale has an inverted range (max, min) and we need to compute the absolute scale width instead. * Add functional test for Y axis scale type switching * Remove unnecessary waitUntilLoadingHasFinished * Skip scale tick tests because of possible flakyness (#21641)
markov00
added a commit
that referenced
this pull request
Aug 3, 2018
…k tests because of possible flakyness (#21641) (#21648) * Fix hidden ticks when using log scale (#21507) * Add support for vertical axis The vertical axis scale has an inverted range (max, min) and we need to compute the absolute scale width instead. * Add functional test for Y axis scale type switching * Remove unnecessary waitUntilLoadingHasFinished * Skip scale tick tests because of possible flakyness (#21641)
💚 Build Succeeded |
liza-mae
added
failed-test
A test failure on a tracked branch, potentially flaky-test
and removed
flaky-failing-test
labels
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip flaky tests identified by #21642 on scale checks