Chromium reports via puppeteer #21788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
to try to repro a Chromium bug.
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
Moved the main scripting logic into Python, as it's a pre-req for building Chromium, and it's more suited to system scripting of this nature. Added scripts to initialize the Chromium build environments.
💔 Build Failed |
💔 Build Failed |
attempt to get around a runtime error.
💚 Build Succeeded |
There was a problem hiding this comment.
omg this PR is awesome!
Code looks good, let me pull down and play around with some reports before LGTM.
Build instructions are great, and I followed for linux, and am in the process of building. Not going to go through all of them due to time constraints. :)
| @@ -135,6 +136,7 @@ | |||
| "polished": "^1.9.2", | |||
| "prop-types": "^15.6.0", | |||
| "puid": "1.0.5", | |||
| "puppeteer-core": "^1.7.0", | |||
There was a problem hiding this comment.
I think now we can drop chrome-remote-interface?
There was a problem hiding this comment.
Hm. Yes. You're right. I thought I'd done it. This is why we have code-reviews, eh?
💔 Build Failed |
|
retest |
stacey-gammon
approved these changes
Aug 29, 2018
💔 Build Failed |
💚 Build Succeeded |
This was referenced Aug 30, 2018
jarpy
added a commit
to elastic/kibana-docker
that referenced
this pull request
Sep 17, 2018
Kibana installs headless browsers at runtime. We can't control the permissions of these files at build time, so we should not make assertions about those permissions. This patch excludes new files that were added by elastic/kibana#21788. Fixes #99
jarpy
added a commit
to elastic/kibana-docker
that referenced
this pull request
Sep 17, 2018
Kibana installs headless browsers at runtime. We can't control the permissions of these files at build time, so we should not make assertions about those permissions. This patch excludes new files that were added by elastic/kibana#21788. Fixes #99
jarpy
added a commit
to elastic/kibana-docker
that referenced
this pull request
Sep 17, 2018
Kibana installs headless browsers at run time. We can't control the permissions of these files at build time, so we should not make assertions about those permissions. This patch excludes new files that were added by elastic/kibana#21788. Fixes #99
jarpy
added a commit
to elastic/kibana-docker
that referenced
this pull request
Sep 17, 2018
Kibana installs headless browsers at run time. We can't control the permissions of these files at build time, so we should not make assertions about those permissions. This patch excludes new files that were added by elastic/kibana#21788. Fixes #99
jarpy
added a commit
to elastic/kibana-docker
that referenced
this pull request
Sep 17, 2018
Kibana installs headless browsers at run time. We can't control the permissions of these files at build time, so we should not make assertions about those permissions. This patch excludes new files that were added by elastic/kibana#21788. Fixes #99
|
|
||
| for (let pageNum = 0; pageNum <= expectedPages; ++pageNum) { |
There was a problem hiding this comment.
Just FYI, I think we need to bring back the retry loop. Just hit the "Failed to convert page to image" error in a PR here: #24109 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our Chromium reports to use an upgraded, custom build of Chromium. It changes the driver to use Puppeteer.
I've tested it repeatedly in CI using this branch: #22383, which strips out all tests but the Chromium ones, so I could iterate CI faster.
Testing
xpack.reporting.capture.browser.type: chromium)