You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?
Thanks for the fix, @aaronoah! The Jest snapshots for this component will need to be updated otherwise CI will fail. You can run this from the root directory with node scripts/jest -u.
@jen-huang Thanks for helping me! I tried to update the snapshots but it didn't seem to have obsolete ones. Could you check it again? I've rewound the head against the master
@aaronoah My mistake! We have jest tests for the functionality of the action buttons, but they do not render snapshots, so this change does not need snapshot updates 🙂Kicking off CI now, thank you!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aaronoah
force-pushed
the
settings-btn-fix
branch
from
Closes #21720.
@bhavyarm