Re-enable dead-code removal for React DevTools #21904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added
blocker
review
Team:Operations
tylersmalley
changed the title
spalger
approved these changes
Aug 12, 2018
| warnings: false, | ||
| negate_iife: false, | ||
| keep_fnames: true, | ||
| keep_infinity: true, |
There was a problem hiding this comment.
I kinda wish all the trues were together at the top or something, but I don't care
There was a problem hiding this comment.
These are to disable functionality enabled by default in the compressor. The UglifyJS options aren't really consistent in that respect. https://github.com/mishoo/UglifyJS2/tree/v2.x
💚 Build Succeeded |
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Aug 12, 2018
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
that referenced
this pull request
Aug 12, 2018
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Aug 12, 2018
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
that referenced
this pull request
Aug 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #21809 we disabled compression for JS assets. However, this raises an issue for those with React DevTools installed, throwing the following error:
Re-enabling these functions requires ~11% more memory, though still keeping us under a 1GB heap. It also increases the production build time by 30%. While overall this is still an improvement from where we started prior to #21809, it gets us out of the OOM issue originally causing these changes.
Going forward, we should apply compression on the code during the build to avoid it entirely in production.