Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make core responsible for reading and merging of config files. Simplify legacy config adapter. #21956

Merged
merged 8 commits into from
Aug 28, 2018
Merged

Make core responsible for reading and merging of config files. Simplify legacy config adapter. #21956

merged 8 commits into from
Aug 28, 2018

Commits on Aug 24, 2018

  1. Make core responsible for reading and merging of config files. Simp… 

    …lify legacy config adapter.
    @azasypkin
    azasypkin committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    51fb213 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2018

  1. Merge branch 'master' into issue-xxx-core-raw-config

    @azasypkin
    azasypkin committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    fe99940 View commit details
    Browse the repository at this point in the history

  2. ObjectToRawConfigAdapter.rawValue can stay private.

    @azasypkin
    azasypkin committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    9c04cd5 View commit details
    Browse the repository at this point in the history

  3. Rename RawConfig to Config and make separation between plain Java… 

    …Script raw config and `Config` class instance.
    @azasypkin
    azasypkin committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    2b15fac View commit details
    Browse the repository at this point in the history

  4. Use ReplaySubject instead of BehaviorSubject in RawConfigService.

    @azasypkin
    azasypkin committed Aug 28, 2018
    3 Configuration menu
    Copy the full SHA
    d21d693 View commit details
    Browse the repository at this point in the history

  5. Make key argument optional in read_config.merge.

    @azasypkin
    azasypkin committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    9678afc View commit details
    Browse the repository at this point in the history

  6. Remove <number> debug leftover.

    @azasypkin
    azasypkin committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    a2f0001 View commit details
    Browse the repository at this point in the history

  7. Specify value type explicitly in ReplaySubject.

    @azasypkin
    azasypkin committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    f4a6a36 View commit details
    Browse the repository at this point in the history