Translations for tutorial common #22071

yankouskia · 2018-08-16T14:50:11Z

#21957

yankouskia · 2018-08-16T15:13:32Z

While review, please take a look at this change https://github.com/elastic/kibana/pull/22071/files#diff-0ecec7148543bea6ae26878ede20ce1eL202. Looks like misspelling in path C:\\Program Files\\Filebeat\\metricbeat.yml instead of C:\\Program Files\\Metricbeat\\metricbeat.yml

elasticmachine · 2018-08-16T16:40:27Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

yankouskia · 2018-08-16T17:47:22Z

retest

elasticmachine · 2018-08-16T18:40:17Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-08-17T08:53:47Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-08-17T09:44:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-08-17T10:24:05Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-08-17T10:42:31Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-08-17T13:07:09Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…s/tutorial-common

elasticmachine · 2018-08-17T15:41:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

tsullivan

Found some spot to look at.

tsullivan · 2018-08-22T21:14:46Z

src/core_plugins/kibana/common/tutorials/filebeat_instructions.js

+        defaultMessage: 'Download and install Filebeat',
+      }),
+      textPre: i18n.translate('kbn.common.tutorials.filebeatInstructions.install.windowsTextPre', {
+        // eslint-disable-next-line


Let's change this to eslint-disable-next-line no-multi-str so that not every eslint rule will be disabled

There are other cases in this file too, and the comment here applies to all of them.

tsullivan · 2018-08-22T21:20:02Z

src/core_plugins/kibana/common/tutorials/filebeat_instructions.js

-      title: 'Install Elasticsearch GeoIP and user agent plugins',
-      textPre: 'This module requires two Elasticsearch plugins that are not ' +
-               'installed by default.\n\nFrom the Elasticsearch installation folder, run:',
+      title: i18n.translate('kbn.common.tutorials.filebeatInstructions.plugins.geoipUiTitle', {


Looks like this is supposed to be kbn.common.tutorials.filebeatInstructions.plugins.geoipUaTitle, not UiTitle

tsullivan · 2018-08-22T21:20:18Z

src/core_plugins/kibana/common/tutorials/filebeat_instructions.js

+      title: i18n.translate('kbn.common.tutorials.filebeatInstructions.plugins.geoipUiTitle', {
+        defaultMessage: 'Install Elasticsearch GeoIP and user agent plugins',
+      }),
+      textPre: i18n.translate('kbn.common.tutorials.filebeatInstructions.plugins.geoipUiTextPre', {


kbn.common.tutorials.filebeatInstructions.plugins.geoipUaTextPre

tsullivan · 2018-08-22T21:20:56Z

src/core_plugins/kibana/common/tutorials/filebeat_instructions.js

+      title: i18n.translate('kbn.common.tutorials.filebeatInstructions.plugins.geoipTitle', {
+        defaultMessage: 'Install Elasticsearch GeoIP plugin',
+      }),
+      textPre: i18n.translate('kbn.common.tutorials.filebeatInstructions.plugins.geoipUiTextPre', {


kbn.common.tutorials.filebeatInstructions.plugins.geoipTextPre

tsullivan · 2018-08-22T21:21:31Z

src/core_plugins/kibana/common/tutorials/filebeat_instructions.js

    },
    DEB: {
-      title: 'Enable and configure the ' + moduleName + ' module',
+      title: i18n.translate('kbn.common.tutorials.filebeatEnableInstructions.devTitle', {


kbn.common.tutorials.filebeatEnableInstructions.debTitle

tsullivan · 2018-08-22T21:22:47Z

src/core_plugins/kibana/common/tutorials/metricbeat_instructions.js

    },
    DEB: {
-      title: 'Enable and configure the ' + moduleName + ' module',
+      title: i18n.translate('kbn.common.tutorials.metricbeatEnableInstructions.devTitle', {


kbn.common.tutorials.metricbeatEnableInstructions.debTitle

tsullivan · 2018-08-22T21:31:25Z

src/core_plugins/kibana/common/tutorials/onprem_cloud_instructions.js

+      do not already have an account. Free 14-day trial available.\n\n\
+      Log into the Elastic Cloud console\n\n\
+      To create a cluster, in Elastic Cloud console:\n\
+      1. Select **Create Deployment** and specify the **Deployment Name**\n\


I don't think it will make a difference in the output text, but let's keep the extra space of indentation in front of each number here to keep a clear outline

elasticmachine · 2018-08-28T13:16:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

tsullivan · 2018-08-28T21:45:37Z

src/core_plugins/kibana/common/tutorials/filebeat_instructions.js

      commands: [
        'curl -L -O https://artifacts.elastic.co/downloads/beats/filebeat/filebeat-{config.kibana.version}-x86_64.rpm',
        'sudo rpm -vi filebeat-{config.kibana.version}-x86_64.rpm',
      ],
-      textPost:
-        'Looking for the 32-bit packages? See the [Download page](https://www.elastic.co/downloads/beats/filebeat).',
+      textPost: i18n.translate('kbn.common.tutorials.filebeatInstructions.install.debTextPost', {


kbn.common.tutorials.filebeatInstructions.install.rpmTextPost

tsullivan

found one more duplicated string ID

elasticmachine · 2018-09-03T12:13:03Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

LeanidShutau · 2018-09-04T09:50:30Z

src/core_plugins/kibana/common/tutorials/filebeat_instructions.js

+        defaultMessage: 'Download and install Filebeat',
+      }),
+      textPre: i18n.translate('kbn.common.tutorials.filebeatInstructions.install.windowsTextPre', {
+        // eslint-disable-next-line no-multi-str


no-multi-str rule is disabled in eslint config

LeanidShutau · 2018-09-04T10:14:37Z

src/core_plugins/kibana/common/tutorials/filebeat_instructions.js

+ 2. Extract the contents of the zip file into {folderPath}.\n\
+ 3. Rename the `{directoryName}` directory to `Filebeat`.\n\
+ 4. Open a PowerShell prompt as an Administrator (right-click the PowerShell icon and select\
+**Run As Administrator**). If you are running Windows XP, you might need to download and install PowerShell.\n\


'... and selectRun As Administrator) ...'
Whitespace shouldn't be removed here

LeanidShutau · 2018-09-04T10:32:09Z

src/core_plugins/kibana/common/tutorials/metricbeat_instructions.js

+ 2. Extract the contents of the zip file into {folderPath}.\n\
+ 3. Rename the {directoryName} directory to `Metricbeat`.\n\
+ 4. Open a PowerShell prompt as an Administrator (right-click the PowerShell icon and select\
+**Run As Administrator**). If you are running Windows XP, you might need to download and install PowerShell.\n\


Same typo here

elasticmachine · 2018-09-04T13:01:52Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

maryia-lapata · 2018-09-04T13:12:27Z

retest

elasticmachine · 2018-09-04T14:43:57Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

maryia-lapata · 2018-09-04T18:54:56Z

retest

elasticmachine · 2018-09-04T21:37:17Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

tsullivan

LGTM

* filebeat_instructions translations * tutorials common * fix translations * use unicode code * folder path to variable * Fix message id * Remove disabling no-multi-str rule, remove spaces

yankouskia added 2 commits August 16, 2018 15:29

filebeat_instructions translations

d94e37c

tutorials common

e771aa4

fix translations

feb1e2b

use unicode code

6d54671

yankouskia force-pushed the feature/translations/tutorial-common branch from bb8acb0 to 78056cc Compare August 17, 2018 10:28

folder path to variable

e0bcbfc

yankouskia force-pushed the feature/translations/tutorial-common branch from 78056cc to e0bcbfc Compare August 17, 2018 11:25

Merge remote-tracking branch 'kibana/master' into feature/translation…

20b4198

…s/tutorial-common

LeanidShutau added the Project:i18n label Aug 21, 2018

tsullivan self-requested a review August 21, 2018 20:55

yankouskia added blocked :Sharing labels Aug 22, 2018

tsullivan requested changes Aug 22, 2018

View reviewed changes

resolve conflicts, fix review issues

e760f91

yankouskia removed the blocked label Aug 28, 2018

yankouskia requested a review from tsullivan August 28, 2018 15:00

tsullivan reviewed Aug 28, 2018

View reviewed changes

tsullivan requested changes Aug 28, 2018

View reviewed changes

Merge branch 'master' into feature/translations/tutorial-common

4dda3ab

Merge branch 'master' into feature/translations/tutorial-common

2d2145a

elastic deleted a comment from elasticmachine Sep 3, 2018

maryia-lapata requested review from LeanidShutau and tsullivan and removed request for tsullivan September 4, 2018 06:57

LeanidShutau suggested changes Sep 4, 2018

View reviewed changes

maryia-lapata added 2 commits September 4, 2018 13:53

Merge branch 'master' into feature/translations/tutorial-common

e417329

Remove disabling no-multi-str rule, remove spaces

670368d

LeanidShutau self-requested a review September 5, 2018 12:32

LeanidShutau approved these changes Sep 5, 2018

View reviewed changes

maryia-lapata requested review from tsullivan and removed request for tsullivan September 5, 2018 15:17

tsullivan approved these changes Sep 5, 2018

View reviewed changes

maryia-lapata merged commit 8d8513c into elastic:master Sep 6, 2018

maryia-lapata deleted the feature/translations/tutorial-common branch September 6, 2018 06:55

maryia-lapata mentioned this pull request Sep 6, 2018

[6.x] Translations for tutorial common (#22071) #22752

Merged

maryia-lapata added backported v6.5.0 labels Sep 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Translations for tutorial common #22071

Translations for tutorial common #22071

yankouskia commented Aug 16, 2018

yankouskia commented Aug 16, 2018

elasticmachine commented Aug 16, 2018

yankouskia commented Aug 16, 2018

elasticmachine commented Aug 16, 2018

elasticmachine commented Aug 17, 2018

elasticmachine commented Aug 17, 2018

elasticmachine commented Aug 17, 2018

elasticmachine commented Aug 17, 2018

elasticmachine commented Aug 17, 2018

elasticmachine commented Aug 17, 2018

tsullivan left a comment

tsullivan Aug 22, 2018

tsullivan Aug 22, 2018

tsullivan Aug 22, 2018

tsullivan Aug 22, 2018

tsullivan Aug 22, 2018

tsullivan Aug 22, 2018

tsullivan Aug 22, 2018

tsullivan Aug 22, 2018

elasticmachine commented Aug 28, 2018

tsullivan Aug 28, 2018

tsullivan left a comment

elasticmachine commented Sep 3, 2018

LeanidShutau Sep 4, 2018

LeanidShutau Sep 4, 2018

LeanidShutau Sep 4, 2018

elasticmachine commented Sep 4, 2018

maryia-lapata commented Sep 4, 2018

elasticmachine commented Sep 4, 2018

maryia-lapata commented Sep 4, 2018

elasticmachine commented Sep 4, 2018

tsullivan left a comment

Translations for tutorial common #22071

Translations for tutorial common #22071

Conversation

yankouskia commented Aug 16, 2018

yankouskia commented Aug 16, 2018

elasticmachine commented Aug 16, 2018

💔 Build Failed

yankouskia commented Aug 16, 2018

elasticmachine commented Aug 16, 2018

💔 Build Failed

elasticmachine commented Aug 17, 2018

💔 Build Failed

elasticmachine commented Aug 17, 2018

💔 Build Failed

elasticmachine commented Aug 17, 2018

💔 Build Failed

elasticmachine commented Aug 17, 2018

💔 Build Failed

elasticmachine commented Aug 17, 2018

💚 Build Succeeded

elasticmachine commented Aug 17, 2018

💚 Build Succeeded

tsullivan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Aug 28, 2018

💚 Build Succeeded

Choose a reason for hiding this comment

tsullivan left a comment

Choose a reason for hiding this comment

elasticmachine commented Sep 3, 2018

💚 Build Succeeded

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Sep 4, 2018

💔 Build Failed

maryia-lapata commented Sep 4, 2018

elasticmachine commented Sep 4, 2018

💔 Build Failed

maryia-lapata commented Sep 4, 2018

elasticmachine commented Sep 4, 2018

💚 Build Succeeded

tsullivan left a comment

Choose a reason for hiding this comment