skip filtering flaky tests #22193
Merged
skip filtering flaky tests #22193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
|
Random xpack failure, could not build es. jenkins, test this |
It is not very random. I saw one of those this morning |
💚 Build Succeeded |
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Aug 20, 2018
stacey-gammon
added a commit
that referenced
this pull request
Aug 21, 2018
liza-mae
added
failed-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are still flaky (see #20442)
I suspect that in the case of the filtering dashboard, there are so many elements on the page that it fails to find all of the elements within the 10 second timeout period. I think to fix this, we need to allow waitForRender to override the default timeout. But in the mean time lets get the build stabilized again.