[Infra UI] Improve built-in log reconstruction rules for development and demos #22213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
review
:Ingest UI
Feature:Metrics UI
💔 Build Failed |
weltenwort
force-pushed
the
infra-ui-enhancement-add-more-rules
branch
from
e713571 to
f320592
Compare
💔 Build Failed |
skh
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the built-in rules for log message reconstruction into separate files for filebeat modules. It also adds a few basic rules for:
I've represented the spaces as separate constants in some rules to anticipate the addition of a "role" property (e.g. "log facility") to each log message segment. Once those are added, segments can be treated according to their role in the UI.