Emit error if api is not stopped and exit code is greater than zero #22224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
liza-mae
added a commit
to liza-mae/kibana
that referenced
this pull request
Aug 22, 2018
liza-mae
added a commit
to liza-mae/kibana
that referenced
this pull request
Aug 22, 2018
liza-mae
added a commit
that referenced
this pull request
Aug 22, 2018
liza-mae
added a commit
that referenced
this pull request
Aug 22, 2018
💔 Build Failed |
|
We might need to revert this - @silne30 believes this is the cause for the ESCONNRESET's and the failed snapshots. |
|
Reverting this will break the Windows tests |
|
Can I get some more information on what ESCONNRESET error is? |
|
I think I originally had this under an if statement for the windows platform so I can do that if that helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A partial fix for when chromedriver exists abnormally on windows in headless mode. There may still be a problem with killing processes on windows, but that error may be less frequent.
Issue: #22094
Part of issue: #21315