-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs Sample Data #22276
Logs Sample Data #22276
Conversation
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! eCommerce next?
Updated PR so that it now has a working index pattern. New screenshot and sample doc above. @jamiesmith @asawariS would love some feedback on the visualization types shown here, metrics to track, etc. Any thoughts on a color schema would be great as well. I'd still like to add annotations to the TSVB chart and better metrics in the table. There needs to be some cleanup, but this is actually a dashboard I use for demo's pretty frequently. More to show off functionality, not necessarily tell a story. @jamiesmith I know we talked about adding "Elasticy" hosts, requests, etc. Any input here from PMM would be great, I'd really like to make this data fun. I know that you were also thinking of anomalies to add in. Note that I made a few changes in the Sample Data Clean Up doc and removed @nreese open question here around tests. Do I need to add them in if there are already some for flight sample data? I'm guessing I do, but thought I'd ask before I write any 😄 |
I think we should add a test that installs the sample data set, opens the dashboard and makes sure the expected number of panels are opened, and then uninstalls the sample data set. I can work on this and give you a PR with the tests. |
💚 Build Succeeded |
@nreese I should be able to add them, will ping with questions. Thanks for the input! |
@nreese I'm assuming I can pretty much copy what you did with flights here |
@alexfrancoeur yes, just don't copy the skipped tests. Simply opening the dashboard and verifying the panel count is good enough for now. |
💚 Build Succeeded |
Still iterating on the data set a bit with @jamiesmith, updated screenshot and doc in the summary. We're close! |
@nreese how do those tests look? |
@alexfrancoeur tests look great. Nice work adding another data set |
💔 Build Failed |
@@ -87,15 +106,40 @@ export default function ({ getService, getPageObjects }) { | |||
const tsvb = await find.existsByCssSelector('.vega-view-container'); | |||
expect(tsvb).to.be(true); | |||
}); | |||
|
|||
it.skip('should launch sample logs data set dashboard', async ()=> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test should not be skipped. It is failing because PageObjects.home.launchSampleDataSet('logs')
needs to be run from from the kibana home page tutorial_directory/sampleData
. You had it right by changing after
to afterEach
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:doh:
it('should uninstall logs sample data set', async ()=> { | ||
await PageObjects.home.removeSampleDataSet('logs'); | ||
await retry.try(async () => { | ||
const successToastExists = await PageObjects.home.doesSampleDataSetSuccessfulUninstallToastExist(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the check for the toast notifications. Those are flaky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ removed, testing locally (because I just figured out how to do that 😄 )
it('should install logs sample data set', async ()=> { | ||
await PageObjects.home.addSampleDataSet('logs'); | ||
await retry.try(async () => { | ||
const successToastExists = await PageObjects.home.doesSampleDataSetSuccessfulInstallToastExist(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the check for the toast notifications. Those are flaky.
💔 Build Failed |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Nice to have another sample data set with a great looking dashboard
lgtm
code review, installed sample data set and viewed dashboard.
nice! thank you @nreese 😄 |
@alexfrancoeur @nreese Great job on the sample web logs!!
|
It was all @alexfrancoeur. |
@nreese stop being modest - I copied all your code 😄 @AlonaNadler great feedback! Updated and committed. Once green, I'll merge |
💔 Build Failed |
jenkins, test this |
💚 Build Succeeded |
Log sample data, check ✅
💚 Build Succeeded |
This is one of the data sets we'd like to add for sample data. This is my first take on the data set itself so open to any feedback.
We're using makelogs as the basis here but want to tweak the URL's and requests to be more Elastic-y.
Open to feedback on the dataset, dashboards, etc.
Also note that I did not add any tests. There were a bunch of sample flight data, I'm not sure if they're necessary for other sample data sets. I'll look for @nreese here for guidance and can add some in if necessary.
Screenshots
Sample document