Removes ui-framework/TableInfo component, uses div instead #22310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenlouv
approved these changes
Aug 23, 2018
|
Thank yoou! Less tech debt. The codebase is already loving you <3 |
💔 Build Failed |
|
retest this please |
💚 Build Succeeded |
jasonrhodes
added a commit
to jasonrhodes/kibana
that referenced
this pull request
Aug 27, 2018
jasonrhodes
added a commit
that referenced
this pull request
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component wasn't needed, it only added a class attached to some global styling, most of which we were overriding anyway. Switched to using a div with styles applied.
Note: punting on the other component swap mentioned in #19590 for now, as it sounds like there is a bit more to discuss on breadcrumb management, and there is some document title management happening in the current implementation.