Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible flakiness of saveVisualization action #22356

Merged
merged 6 commits into from
Aug 30, 2018
Merged

Fix possible flakiness of saveVisualization action #22356

merged 6 commits into from
Aug 30, 2018

Commits on Aug 27, 2018

  1. Updated saveVisualization to wait for toast instead of global indicator

    @markov00
    markov00 committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    f4120f4 View commit details
    Browse the repository at this point in the history

  2. Fix RBAC tests. 

    The saveVisualization now fails directly if the visualization is not correctly saved.
    @markov00
    markov00 committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    f2a0525 View commit details
    Browse the repository at this point in the history

  3. Change editor to use toast for errors

    @markov00
    markov00 committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    b30f6fd View commit details
    Browse the repository at this point in the history

  4. Change saveVisualization method to new saveVisualizationExpectSuccess 

    For RBAC tests used also saveVisualizationExpectFail
    @markov00
    markov00 committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    b49fc71 View commit details
    Browse the repository at this point in the history

  5. Fix wrong exists method call

    @markov00
    markov00 committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    83ec6bc View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2018

  1. Fix missing exist function

    @markov00
    markov00 committed Aug 28, 2018
    Configuration menu
    Copy the full SHA
    70b24a5 View commit details
    Browse the repository at this point in the history