-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated test to retry assertions. Also fixed os specific key binding … #22421
Conversation
@silne30 what do you think about splitting these into two PRs ? |
@liza-mae I thought about that but since the code was one if statement for the handling of the different key binding, seemed like overkill. |
💚 Build Succeeded |
@bhavyarm thanks for testing this, here are some instructions: |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gauge test in this file failed for me when running on cloud. An update to that test is in #22472 let's merge that in here and also update topN label test with the same, since I suspect it will have the same problem. What do you think of using the same coding convention on retry block as other tests. Also do we need to update all the tests to use retry that are doing similar checks?
💚 Build Succeeded |
Duplicate of #22521 |
Fixes #22230 and #22331