[chrome/urlOverflowCheck] use modifyUrl helper
#22435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Core
💚 Build Succeeded |
|
Will review and test on my Windows VM today. |
azasypkin
approved these changes
Aug 28, 2018
There was a problem hiding this comment.
LGTM, I think I was able to reproduce original issue locally on master and confirmed that it's not reproducible with this PR.
Steps to reproduce I followed (with local code change):
- ngnix config:
server {
listen 8080;
server_name kibana;
location ~ ^/kibana/(.*)$ {
rewrite /kibana/(.*) /$1 break;
proxy_pass http://localhost:5601;
proxy_http_version 1.1;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection 'upgrade';
proxy_set_header Host $host;
proxy_cache_bypass $http_upgrade;
}
}
-
Change this value to something smaller so that you can reproduce the issue with a bunch of visualizations in any browser, e.g.
2500 -
Run Kibana with
node scripts/kibana --oss --server.basePath=/kibana --server.rewriteBasePath=false
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Aug 28, 2018
Fixes elastic#18835 This updates the url-overflow redirect to use the `modifyUrl()` helper which was written almost exclusively to help deal with the confusion that node's `path` and `pathname` nonsense creates. I tested this in Edge and things seem to work well, but I'd appreciate if @baracudda or @chandanpal could checkout this PR and see if it works for them.
spalger
pushed a commit
that referenced
this pull request
Aug 29, 2018
Fixes #18835 This updates the url-overflow redirect to use the `modifyUrl()` helper which was written almost exclusively to help deal with the confusion that node's `path` and `pathname` nonsense creates. I tested this in Edge and things seem to work well, but I'd appreciate if @baracudda or @chandanpal could checkout this PR and see if it works for them.
|
6.x/6.5: ae8cbe3 |
|
@spalger thanks for the fix. i will test it and let you know. is this fix will come under 6.5 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18835
This updates the url-overflow redirect to use the
modifyUrl()helper which was written almost exclusively to help deal with the confusion that node'spathandpathnamenonsense creates. I tested this in Edge and things seem to work well, but I'd appreciate if @baracudda or @chandanpal could checkout this PR and see if it works for them.