Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional test to surface index version conflicts #22509

Merged
merged 6 commits into from
Aug 30, 2018

Conversation

bhavyarm
Copy link
Contributor

Tests for: #22018

This test:

  1. Creates a scripted field on logstash index, uses es client to update the field format of another field in the same index pattern and tries to save the scripted field. Expects Kibana to display version conflict refresh your page message
  2. Tries to update the field format of a field in logstash index, uses es client to update the field format of another field and tries to save the updated field format of first field. Expects Kibana to display version conflict refresh your page message

@bhavyarm bhavyarm requested a review from LeeDr August 29, 2018 18:31
@elasticmachine
Copy link
Contributor

💔 Build Failed

@bhavyarm
Copy link
Contributor Author

jenkins, test this!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Code review and checked Jenkins results. Only takes 17 seconds to run :-)

17:22:48        └-: index version conflict
17:22:48          └-> "before all" hook
17:22:48          └-> "before all" hook
17:22:50          └-> Should be able to surface version conflict notification while creating scripted field
17:22:50            └-> "before each" hook: global before each
17:22:58            └- ✓ pass 
17:22:58          └-> Should be able to surface version conflict notification while changing field format
17:22:58            └-> "before each" hook: global before each
17:23:05            └- ✓ pass 
17:23:05          └-> "after all" hook
17:23:05        └-> "after all" hook
17:23:05        └-> "after all" hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants