Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESLint] Turn off no-multi-str rule in eslint config #22525

Merged
merged 2 commits into from
Aug 31, 2018
Merged

[ESLint] Turn off no-multi-str rule in eslint config #22525

merged 2 commits into from
Aug 31, 2018

Conversation

tsullivan
Copy link
Member

Resolves #22524

@tsullivan tsullivan added review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v6.5.0 labels Aug 30, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

azasypkin
azasypkin approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI.

@tsullivan
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

spalger
spalger approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsullivan tsullivan merged commit f2e4282 into elastic:master Aug 31, 2018
@tsullivan tsullivan deleted the lint/no-multi-str0 branch August 31, 2018 16:55
@tsullivan tsullivan mentioned this pull request Aug 31, 2018
Merged
tsullivan added a commit to tsullivan/kibana that referenced this pull request Aug 31, 2018
@tsullivan
[ESLint] Turn off no-multi-str rule in eslint config (elastic#22525)
ea25ab5 
* remove inline rule disabling comments

* turn off no-multi-str
tsullivan added a commit that referenced this pull request Aug 31, 2018
@tsullivan
[ESLint] Turn off no-multi-str rule in eslint config (#22525) (#22602)
c80a34f 
* remove inline rule disabling comments

* turn off no-multi-str
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsullivan @elasticmachine @spalger @azasypkin