Add the new chromium windows path to the CI "CleanExtraBrowsersTask" #22534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't know about this bit of the codebase. It would be ideal if it didn't have to know about our browser naming conventions, but for now, it does. |
stacey-gammon
approved these changes
Aug 30, 2018
💚 Build Succeeded |
chrisdavies
added a commit
to chrisdavies/kibana
that referenced
this pull request
Aug 30, 2018
chrisdavies
added a commit
that referenced
this pull request
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Chromium naming convention is windows, not win32. Adding this to the CleanExtraBrowsersTask in CI.