Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react vis type documentation #22573

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Fix react vis type documentation #22573

merged 1 commit into from
Sep 5, 2018

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Aug 31, 2018

Fix the React vis type documentation. The component key was wrongly named template in the documentation.

@timroes timroes added Team:Docs Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v7.0.0 v6.4.0 v6.5.0 labels Aug 31, 2018
ppisljar
ppisljar approved these changes Aug 31, 2018
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

markov00
markov00 approved these changes Aug 31, 2018
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timroes
Copy link
Contributor Author

timroes commented Sep 4, 2018

Jenkins, test this

@timroes timroes added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. and removed v6.4.0 labels Sep 4, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes
Copy link
Contributor Author

timroes commented Sep 4, 2018

Jenkins, test this - flaky reporting test I think

@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes
Copy link
Contributor Author

timroes commented Sep 4, 2018

Jenkins, test this - another flaky ES build

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes merged commit 9c01863 into elastic:master Sep 5, 2018
@timroes timroes added v6.4.0 and removed release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. labels Sep 5, 2018
@timroes timroes deleted the fix-react-vis-doc branch September 5, 2018 07:35
@timroes timroes mentioned this pull request Sep 5, 2018
Merged
timroes added a commit to timroes/kibana that referenced this pull request Sep 5, 2018
@timroes
Fix react vis type documentation (elastic#22573)
db5b829
@timroes timroes mentioned this pull request Sep 5, 2018
Merged
timroes added a commit to timroes/kibana that referenced this pull request Sep 5, 2018
@timroes
Fix react vis type documentation (elastic#22573)
d290a11
timroes added a commit that referenced this pull request Sep 5, 2018
@timroes
Fix react vis type documentation (#22573) (#22705)
b555c82
timroes added a commit that referenced this pull request Sep 5, 2018
@timroes
Fix react vis type documentation (#22573) (#22704)
242afa7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Docs v6.4.0 v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timroes @elasticmachine @markov00 @ppisljar