[APM] Fix broken links

[sorenlouv]

Some links were missing the basepath

[sorenlouv]

The test here feel a little unnecessary. Let me know if you any suggestions.

[jasonrhodes]

Yeah I see what you mean but I think it's fine to be a little extra explicit with what we're worried about there with base paths.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

Pinging @elastic/apm-ui

[jasonrhodes]

There are a couple other places where these similar links are broken:

• getMlJobUrl() returns a link that isn't dynamic per base path, it's used in the Flyout here
  • could maybe use <KibanaLink> inside of that function and let the base path get added in one place, possibly?
• You could possibly also use KibanaLink as a node passed to the Context Menu which seems better than using chrome in more places, except it doesn't seem like the context menu component wants you to do that very easily so what you have probably makes the most sense for now
• <a href="/app/ml">Machine Learning jobs management page</a> is hard-coded in the Flyout as well, which could use a KibanaLink to fix I think

[sorenlouv]

I could swear I had added base url for getMlJobUrl. Good catch!
I tend to agree with you that we shouldn't add addBasePath all over the place, but I'm hoping to get rid of KibanaLink (at least partly).

In the case with getMlJobUrl if we only need KibanaLink to add basePath, why not use addBasePath directly? EDIT: Actually, I agree with you. I'll remove addBasePath from getMlJobUrl.

[jasonrhodes]

Overall I think I prefer:

<SomeLinkAbstraction path="/some/path" />
<OtherComponent items={[
  <SomeLinkAbstraction path="/other/path" />,
  <Etc>
]} />

in lots of places, rather than:

<a href={someFn("/some/path")} />
<OtherLink path={someFn("/some/path")} />
<OtherComponent items={[
  { href: someFn("/other/path"), otherProp: 'whatever' },
  { etc: 'etc', etc: 'etc' }
]} />
// etc

but if there's history with KibanaLink we can move toward some better abstraction over time :)

[sorenlouv]

@jasonrhodes I agree. I updated my comment (the illegal move - sorry! ;) )

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request