Improve test coverage for CallClient error cases. #22599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
commented
Aug 31, 2018
| }); | ||
|
|
||
| searchRequests = [ searchRequestFail ]; | ||
| const callingClient = callClient(searchRequests); | ||
| it(`calls the errorHandler provided to the searchRequest`, () => { |
There was a problem hiding this comment.
This is the assertion I missed originally.
cjcenizal
commented
Aug 31, 2018
| await callClient(searchRequests); | ||
| } catch(e) { | ||
|
|
||
| return callClient(searchRequests).then(() => { |
There was a problem hiding this comment.
This fixes a bug in the original assertion. The original assertion was never made because callClient doesn't re-throw errors.
💚 Build Succeeded |
This was referenced Aug 31, 2018
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 31, 2018
cjcenizal
added a commit
that referenced
this pull request
Sep 2, 2018
cjcenizal
added a commit
that referenced
this pull request
Sep 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #22558. I realized I missed an important assertion for error cases, and found a couple spots where the assertions were incorrect. I also cleaned up some formatting inconsistencies (sorry for the noise). I'm going to backport this to 6.4 to keep these changes grouped with the changes from the original PR.