Fix #22510, dashboard-only mode doesn't display saved searches #22685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
approved these changes
Sep 4, 2018
There was a problem hiding this comment.
LGTM code review only.
Talked to Chris offline and we will work on adding more tests to cover this separately so we can get this fix in for 6.4.1.
cc @elastic/kibana-qa - to test, just log in as a dashboard only mode user, with access to the data, and try to view a dashboard with a saved search on it. Saved search before would come up blank with a console error, now with this fix, should show up with data.
|
Fixes #22510 |
💔 Build Failed |
|
retest |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
chrisdavies
added a commit
to chrisdavies/kibana
that referenced
this pull request
Sep 5, 2018
chrisdavies
added a commit
to chrisdavies/kibana
that referenced
this pull request
Sep 5, 2018
chrisdavies
added a commit
that referenced
this pull request
Sep 5, 2018
chrisdavies
added a commit
that referenced
this pull request
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dependency on ui/pager to the dashboard-only UI.