Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align staging urls with new endpoints #22691

Merged
merged 1 commit into from
Sep 5, 2018
Merged

align staging urls with new endpoints #22691

merged 1 commit into from
Sep 5, 2018

Conversation

thomasneirynck
Copy link
Contributor

Ensure our stubs do not continue to refer to old crufty URLs, but instead point to the real staging server.

nickpeihl
nickpeihl approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

nyurik
nyurik approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure we want to test against the staging, and not the prod? I'm ok either way

@elasticmachine
Copy link
Contributor

💔 Build Failed

@thomasneirynck
Copy link
Contributor Author

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@thomasneirynck thomasneirynck added chore v7.0.0 [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v6.5.0 v6.4.1 labels Sep 5, 2018
@thomasneirynck thomasneirynck merged commit b791869 into elastic:master Sep 5, 2018
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Sep 5, 2018
@thomasneirynck
align staging urls with new endpoints (elastic#22691)
725450d
@thomasneirynck thomasneirynck mentioned this pull request Sep 5, 2018
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Sep 5, 2018
@thomasneirynck
align staging urls with new endpoints (elastic#22691)
89ccd24
@thomasneirynck thomasneirynck mentioned this pull request Sep 5, 2018
Merged
thomasneirynck added a commit that referenced this pull request Sep 5, 2018
@thomasneirynck
align staging urls with new endpoints (#22691) (#22717)
06e597e
thomasneirynck added a commit that referenced this pull request Sep 5, 2018
@thomasneirynck
align staging urls with new endpoints (#22691) (#22718)
21db47e
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Sep 5, 2018
@thomasneirynck
align staging urls with new endpoints (elastic#22691)
208209f
@thomasneirynck thomasneirynck mentioned this pull request Sep 5, 2018
Merged
thomasneirynck added a commit that referenced this pull request Sep 6, 2018
@thomasneirynck
align staging urls with new endpoints (#22691) (#22741)
e502db2
@thomasneirynck thomasneirynck mentioned this pull request Sep 6, 2018
Merged
@epixa epixa added the test label Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyurik nyurik nyurik approved these changes

@nickpeihl nickpeihl nickpeihl approved these changes

@kindsun kindsun Awaiting requested review from kindsun

Assignees
No one assigned
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation test v5.6.12 v6.2.5 v6.4.1 v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thomasneirynck @elasticmachine @nickpeihl @nyurik @epixa