Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit format parameter to docvalue_fields requests #22771

Merged
merged 7 commits into from
Sep 7, 2018
Merged

Add explicit format parameter to docvalue_fields requests #22771

merged 7 commits into from
Sep 7, 2018

Commits on Sep 6, 2018

  1. Add explicit format parameter to date doc_value requests 

    Fixes elastic#22484

Elasticsearch 6.4 added an optional `format` parameter for doc_value
fields. In 6.x if the param is not included it defaults to returning
the same values we see in scripted fields. In 7.0 this is changing to
use the mapping configured format by default. In kibana we want our date
values in millis, so this PR future proofs us for 7.0. It also eliminates
deprecation warnings ES is returning due to the missing param, which is
currently spamming some users.
    @Bargs
    Bargs committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    69d2658 View commit details
    Browse the repository at this point in the history

  2. Add format param to docvalue_fields sent by top_hits agg

    @Bargs
    Bargs committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    9de1298 View commit details
    Browse the repository at this point in the history

  3. update top_hit test

    @Bargs
    Bargs committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    625d421 View commit details
    Browse the repository at this point in the history

  4. use strict_date_optional_time instead of epoch_millis

    @Bargs
    Bargs committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    d45ac69 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2018

  1. update unit test

    @Bargs
    Bargs committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    c58b63b View commit details
    Browse the repository at this point in the history

  2. use date_time instead per Jim's advice

    @Bargs
    Bargs committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    9ce0767 View commit details
    Browse the repository at this point in the history

  3. fix the source filter for docvalue_fields since the type of object 

    held by docvalue_fields changed
    @Bargs
    Bargs committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    09b5a1c View commit details
    Browse the repository at this point in the history