Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date histogram step to Create Rollup Job Wizard #22789

Merged
merged 13 commits into from
Sep 11, 2018
Merged

Add date histogram step to Create Rollup Job Wizard #22789

merged 13 commits into from
Sep 11, 2018

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Sep 6, 2018 •
edited
Loading

To-do:

  • Block forward progress if async index pattern validation fails
  • Validate that index pattern and rollup index values aren't the same
  • Present date field options in a select

Date histogram step

image

Async index pattern validation

index_pattern_validation

@cjcenizal cjcenizal added WIP Work in progress :Management labels Sep 6, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal cjcenizal force-pushed the rollup-wizard-date-histogram branch from 38f8d5b to cbc8f66 Compare September 7, 2018 00:13
@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal cjcenizal requested a review from jen-huang September 7, 2018 15:28
jen-huang
jen-huang reviewed Sep 7, 2018
View reviewed changes
...lugins/rollup/public/crud_app/sections/job_create/step_date_histogram/step_date_histogram.js
<EuiFieldText
value={dateHistogramInterval || ''}
onChange={e => onFieldsChange({ dateHistogramInterval: e.target.value })}
isInvalid={Boolean(areStepErrorsVisible && errorDateHistogramInterval)}

This comment was marked as resolved.

Sign in to view

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

...lugins/rollup/public/crud_app/sections/job_create/step_date_histogram/step_date_histogram.js
<EuiFieldText
value={dateHistogramDelay || ''}
onChange={e => onFieldsChange({ dateHistogramDelay: e.target.value })}
isInvalid={Boolean(areStepErrorsVisible && errorDateHistogramDelay)}

This comment was marked as resolved.

Sign in to view

...lugins/rollup/public/crud_app/sections/job_create/step_date_histogram/step_date_histogram.js Outdated
description={(
<FormattedMessage
id="xpack.rollupJobs.create.stepDateHistogram.sectionDataStorage.description"
defaultMessage="How should this date histogram data be rolled up?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description can be fleshed out to add something like
How long should we wait before rolling up new documents? By default, the indexer attempts to roll up all data that is available. What time zone should the rollup documents be stored as?

(this is just kind of copied from the rollup docs 😄)

x-pack/plugins/rollup/server/routes/api/indices.js Show resolved Hide resolved
x-pack/plugins/rollup/public/crud_app/sections/job_create/job_create.js Outdated
@@ -6,7 +6,7 @@

import React, { Component, Fragment } from 'react';
import PropTypes from 'prop-types';
import { mapValues, cloneDeep } from 'lodash';
import { mapValues, cloneDeep, debounce } from 'lodash';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we import these separately instead of the entire lodash library?

@jen-huang
Copy link
Contributor

also there is an EUI console error, I think because the form group for ID doesn't have a description:

image

@cjcenizal cjcenizal force-pushed the rollup-wizard-date-histogram branch from 7c80524 to 5365205 Compare September 7, 2018 23:50
@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal
Add validation for date histogram step.
eb4a634 
- Require date field and interval.
- Parse interval and delay for valid format.
- Add ParseEsIntervalInvalidFormatError and ParseEsIntervalInvalidCalendarIntervalError to parseEsInterval module.
@cjcenizal
Copy link
Contributor Author

cjcenizal commented Sep 10, 2018 •
edited
Loading

Validation for date histogram step

image

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal
Copy link
Contributor Author

I consider the form group error to be something to be fixed on the EUI side, but it's also possible this design will change and render the issue moot. So I'm going to wait and address that console error later.

@cjcenizal cjcenizal merged this pull request into elastic:feature/rollups Sep 11, 2018
@cjcenizal cjcenizal deleted the rollup-wizard-date-histogram branch September 11, 2018 01:56
@elasticmachine
Copy link
Contributor

💔 Build Failed

cjcenizal added a commit that referenced this pull request Sep 11, 2018
@cjcenizal
Add date histogram step to Create Rollup Job Wizard (#22789)
77524c4 
* Condense app teardown logic.
* Fix React form error with null values by substituting empty strings.
* Block progression if the form contains errors.
* Validate index pattern as you type.
  - Add /api/rollup/index_pattern_validity/{indexPattern} API endpoint.
  - Check that the index pattern matches indices, does not match rollup indices, and contains time fields.
* Validate that index pattern and rollup index aren't the same.
* Add validation for date histogram step.
  - Require date field and interval.
  - Parse interval and delay for valid format.
  - Add ParseEsIntervalInvalidFormatError and ParseEsIntervalInvalidCalendarIntervalError to parseEsInterval module.
* Apply maxWidth to detail panel.
* Show success toasts when jobs are deleted.
@cjcenizal cjcenizal removed the WIP Work in progress label Sep 13, 2018
cjcenizal added a commit that referenced this pull request Sep 19, 2018
@cjcenizal
Add date histogram step to Create Rollup Job Wizard (#22789)
0bbbe32 
* Condense app teardown logic.
* Fix React form error with null values by substituting empty strings.
* Block progression if the form contains errors.
* Validate index pattern as you type.
  - Add /api/rollup/index_pattern_validity/{indexPattern} API endpoint.
  - Check that the index pattern matches indices, does not match rollup indices, and contains time fields.
* Validate that index pattern and rollup index aren't the same.
* Add validation for date histogram step.
  - Require date field and interval.
  - Parse interval and delay for valid format.
  - Add ParseEsIntervalInvalidFormatError and ParseEsIntervalInvalidCalendarIntervalError to parseEsInterval module.
* Apply maxWidth to detail panel.
* Show success toasts when jobs are deleted.
cjcenizal added a commit that referenced this pull request Sep 28, 2018
@cjcenizal
Add date histogram step to Create Rollup Job Wizard (#22789)
504358c 
* Condense app teardown logic.
* Fix React form error with null values by substituting empty strings.
* Block progression if the form contains errors.
* Validate index pattern as you type.
  - Add /api/rollup/index_pattern_validity/{indexPattern} API endpoint.
  - Check that the index pattern matches indices, does not match rollup indices, and contains time fields.
* Validate that index pattern and rollup index aren't the same.
* Add validation for date histogram step.
  - Require date field and interval.
  - Parse interval and delay for valid format.
  - Add ParseEsIntervalInvalidFormatError and ParseEsIntervalInvalidCalendarIntervalError to parseEsInterval module.
* Apply maxWidth to detail panel.
* Show success toasts when jobs are deleted.
cjcenizal added a commit that referenced this pull request Oct 2, 2018
@cjcenizal
Add date histogram step to Create Rollup Job Wizard (#22789)
c58f60f 
* Condense app teardown logic.
* Fix React form error with null values by substituting empty strings.
* Block progression if the form contains errors.
* Validate index pattern as you type.
  - Add /api/rollup/index_pattern_validity/{indexPattern} API endpoint.
  - Check that the index pattern matches indices, does not match rollup indices, and contains time fields.
* Validate that index pattern and rollup index aren't the same.
* Add validation for date histogram step.
  - Require date field and interval.
  - Parse interval and delay for valid format.
  - Add ParseEsIntervalInvalidFormatError and ParseEsIntervalInvalidCalendarIntervalError to parseEsInterval module.
* Apply maxWidth to detail panel.
* Show success toasts when jobs are deleted.
cjcenizal added a commit that referenced this pull request Oct 4, 2018
@cjcenizal
Add date histogram step to Create Rollup Job Wizard (#22789)
89e978b 
* Condense app teardown logic.
* Fix React form error with null values by substituting empty strings.
* Block progression if the form contains errors.
* Validate index pattern as you type.
  - Add /api/rollup/index_pattern_validity/{indexPattern} API endpoint.
  - Check that the index pattern matches indices, does not match rollup indices, and contains time fields.
* Validate that index pattern and rollup index aren't the same.
* Add validation for date histogram step.
  - Require date field and interval.
  - Parse interval and delay for valid format.
  - Add ParseEsIntervalInvalidFormatError and ParseEsIntervalInvalidCalendarIntervalError to parseEsInterval module.
* Apply maxWidth to detail panel.
* Show success toasts when jobs are deleted.
jen-huang pushed a commit that referenced this pull request Oct 17, 2018
@cjcenizal @jen-huang
Add date histogram step to Create Rollup Job Wizard (#22789)
e0858c9 
* Condense app teardown logic.
* Fix React form error with null values by substituting empty strings.
* Block progression if the form contains errors.
* Validate index pattern as you type.
  - Add /api/rollup/index_pattern_validity/{indexPattern} API endpoint.
  - Check that the index pattern matches indices, does not match rollup indices, and contains time fields.
* Validate that index pattern and rollup index aren't the same.
* Add validation for date histogram step.
  - Require date field and interval.
  - Parse interval and delay for valid format.
  - Add ParseEsIntervalInvalidFormatError and ParseEsIntervalInvalidCalendarIntervalError to parseEsInterval module.
* Apply maxWidth to detail panel.
* Show success toasts when jobs are deleted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen-huang jen-huang jen-huang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjcenizal @elasticmachine @jen-huang