Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spaces] - code cleanup #22802

Merged
merged 9 commits into from
Sep 14, 2018
Merged

[Spaces] - code cleanup #22802

merged 9 commits into from
Sep 14, 2018

Conversation

legrego
Copy link
Member

@legrego legrego commented Sep 7, 2018 •
edited
Loading

[skip ci]

kobelb
kobelb reviewed Sep 7, 2018
View reviewed changes
x-pack/plugins/spaces/server/lib/saved_objects_client/saved_objects_client_wrapper_factory.ts Outdated
import { SavedObjectsClient } from './saved_objects_client_types';
import { SpacesSavedObjectsClient } from './spaces_saved_objects_client';

interface SOCWrapperOptions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this to the saved_objects_client_types?

@elastic elastic deleted a comment from elasticmachine Sep 7, 2018
@cjcenizal cjcenizal added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Sep 7, 2018
@legrego legrego mentioned this pull request Sep 13, 2018
Merged
vikaskyadav
vikaskyadav approved these changes Sep 14, 2018
View reviewed changes
Copy link

@vikaskyadav vikaskyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legrego
Copy link
Member Author

legrego commented Sep 14, 2018

@kobelb I'm merging this to spaces-phase-1 to move forward with final testing, but feel free to re-review at your leisure

@legrego legrego merged commit 79bff57 into elastic:spaces-phase-1 Sep 14, 2018
@legrego legrego deleted the more-spaces-typescript branch September 14, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobelb kobelb kobelb left review comments

@vikaskyadav vikaskyadav vikaskyadav approved these changes

Assignees
No one assigned
Labels
Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legrego @kobelb @vikaskyadav @cjcenizal